Move OptionDescription to utils/options so types agree #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
reviewed
May 28, 2019
|
Looks good, with my minor comment resolved :) |
dcodeIO
reviewed
May 28, 2019
dcodeIO
reviewed
May 28, 2019
| @@ -3,7 +3,7 @@ export interface OptionDescription { | |||
| /** Textual description. */ | |||
| description?: string | string[], | |||
| /** Data type. One of (b)oolean [default], (i)nteger, (f)loat or (s)tring. Uppercase means multiple values. */ | |||
| type?: "b" | "i" | "f" | "s", "I", "F", "S", | |||
| type?: "b" | "i" | "f" | "s" | "I" | "F" | "S", | |||
There was a problem hiding this comment.
nice find! did that even work before?
There was a problem hiding this comment.
Nut sure it was ever used. Since it was just the type definition file and no one tried to use the type with a typescript project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this when using the options parser in as-pect and
asc.exportsdisagreed withutil.parse's expected argument typeConfig.