fix: allow using nullable strings in template literals #2928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CountBleck
changed the title
We basically compile nullable strings down to a ternary: `expr ? expr.toString() : "null"` Fixes AssemblyScript#2918.
CountBleck
force-pushed
the
nullable-template-arg
branch
from
6cbc181 to
52b8b92
Compare
|
Whoops, in my haste to check if I needed to rebase the PR, I forgot that nobody reviewed it yet... |
|
LGTM. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2918.
Changes proposed in this pull request:
⯈ Allow using nullable strings in template literals, by converting
nullto"null"