Skip to content

fix: StaticArray#concat link child to incorrect parent #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2023
Merged

fix: StaticArray#concat link child to incorrect parent #2746

merged 2 commits into from
Sep 27, 2023

Conversation

HerrCai0907
Copy link
Member

Fixes: #2740

CountBleck
CountBleck approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@CountBleck CountBleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent with Array and Map.

@HerrCai0907 HerrCai0907 merged commit 1126ef1 into AssemblyScript:main Sep 27, 2023
@HerrCai0907 HerrCai0907 deleted the fix/StaticArray#concat branch September 27, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGraey MaxGraey MaxGraey approved these changes

@CountBleck CountBleck CountBleck approved these changes

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AssemblyScript crashes with bus error
3 participants
@HerrCai0907 @MaxGraey @CountBleck