-
-
Notifications
You must be signed in to change notification settings - Fork 670
#1125 Fix parsing of unusual trailing expressions separated by whitespace #2252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1125 Fix parsing of unusual trailing expressions separated by whitespace #2252
Conversation
…ated by whitespace
I wonder whether this is only applicable to |
I agree. I don't know the spec well but I should consider more deeply. Anyway, this change counts some valid codes like below as an error. function foo(): i32 {
return 123 } I'll close this pullreq for now and reopen it after making more proper solution. |
I read the spec but it's too complecated for me to handle all cases. Anyway, this pull req can fix issue #1125. If other cases are found, please replace |
Thanks :) There are likely more ASI-related issues, but seems good to have this merged for the (probably most prominent) cases covered herein. |
Concerning:
Is "unexpected token error" appropriate for this error?
Serialized source text still has ";". Is it OK?
I've read the contributing guidelines
I've added my name and email to the NOTICE file