Imported & Exported ES6 Namespaces now contained properties that would have been queuedExports

[torch2424]

closes #1417
relates to #1386
relates to #1415

This completely fixes how queuedExports are added to imported namespaces import * as ImportedNamespace. This creates a map of all importedNamespaces, and then as queued exports are resolve,d they are assigned to the appropriate namespace. It also ensures globals are correctly overriden when we finally generate the code for the said namespace.

And in this process I found serveral more bugs in general in just how namespaces are both imported and exported. And this fixes alllll of that 😄 🎉

@dcodeIO for the review 😄 👍

Screenshots of this working

[dcodeIO]

Thanks for investigating :) Added a few comments above, but I must admit that it's always a challenge to dive into this stuff because the linking is kinda abstract, so not sure how much sense the aliasNamespace suggestion makes. Perhaps you have a better idea how to make this more efficient without introducing new maps and somehow link sibling namespaces to make lookups cheap?

[torch2424]

@dcodeIO

Thanks for investigating :)

You are welcome! I am thoroughly surprised I was able to figure this out actually haha 😂

Added a few comments above, but I must admit that it's always a challenge to dive into this stuff because the linking is kinda abstract, so not sure how much sense the aliasNamespace suggestion makes. Perhaps you have a better idea how to make this more efficient without introducing new maps and somehow link sibling namespaces to make lookups cheap?

So yes! I replied to your comments. Before I update the PR I'll wait to see what your replies are so I have a better idea on what to try to implement.

For the hasGlobal fix, If my comment was correct in that it's a set on our compiler class, than we should be good to go there.

For the Namespace set, yeah I just wanted you to either say I was understanding what you meant, and/or if my whole add functionality to the file class to allow adding exports later to a namespace makes sense.

Either way! Thanks for the review, super excited to get this in 😄

[torch2424]

@dcodeIO Made Requested changes, and tests are passing on my end! This is good to go! 😸

[dcodeIO]

Thanks! 👍 A few more comments above (sorry). I like how the mechanism works now!

[torch2424]

Made requested changes @dcodeIO ! 😄 👍

[torch2424]

Made requested changes! This is good to go @dcodeIO 😄 👍

[dcodeIO]

Looks great, thank you!

[torch2424]

Yooooooooo! 😄 👍 Thanks for the review @dcodeIO 🚀

[github-actions]

🎉 This PR is included in version 0.14.8 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀