-
-
Notifications
You must be signed in to change notification settings - Fork 2
Chapter 6 feedback #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
You changed rotation back to how it was but didn’t mention anywhere, I understand not highlighting incase someone is using the tutorial for quick reference on specifics and not following through but if you are following through then you aren’t necessarily going to be resetting your code between steps so a mention at the start of the section that you’ve set it back/undone the changes made to the rotation in the previous step might help someone who might think they have done something wrong when they make a change and don’t get the same result you are showing. |
Always keep constructor parameters on separate lines, else it is easy to miss specific properties. For example, I missed the May doing different indents here might have helped. |
This was updated to highlight the position code, but the section was also reworded to the following
|
Section has been updated to the following to account for the rotation reset in the code
|
This should have been indented. It's been updated. |
Feedback related to chapter 6
The text was updated successfully, but these errors were encountered: