Add tests for EEPROM #177
Merged
Add tests for EEPROM #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update docs to explain purpose of SampleProjects and avoid impression that they are templates to be followed too closely. - Provide alternative `bundle install` command (the original one doesn't work on macOS 10.16). - Correct location for your project.
jgfoster
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
@ianfixes, With this PR we have tests of the six public APIs for EEPROM and we try read/write of various values and at various points in memory. From my understanding of what EEPROM is supposed to do, we have it implemented and tested completely. Unless you have further suggestions (which are welcome!), I believe this should be merged into tdd and then into master (I can submit a new PR for that after this is merged if you like). Thanks!
|
This looks great, I see the passing tests! |
|
Sorry for the delay on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests the public API