Add Mock Support for EEPROM #174
Conversation
…-CI#171) * Don't define ostream& operator() if already defined by Apple.
cpp/arduino/avr/iomxx0_1.h
Outdated
| * | ||
| * See https://github.com/Arduino-CI/arduino_ci/issues/166#issuecomment-703904394. | ||
| */ | ||
| #define EEPROM_SIZE (4096) |
There was a problem hiding this comment.
It might be more appropriate to conditionally set this variable based on the board being used, which can be done in the default configuration here:
https://github.com/Arduino-CI/arduino_ci/blob/master/misc/default.yml#L102
There was a problem hiding this comment.
I can certainly try that. By way of background, where did those files come from? Why does EEPROM_SIZE exist in over 40 of them?
There was a problem hiding this comment.
I copied them from the Arduino project itself, arduino-1.8.5/hardware/tools/avr/avr/include/avr to get things to compile... some hand-edits were made. I have very little information on how/why Arduino structures these files.
There was a problem hiding this comment.
where did those files come from?
It's avr-libc:
https://www.nongnu.org/avr-libc/
Nothing Arduino-specific. This is just the standard open source AVR toolchain.
There was a problem hiding this comment.
Why does EEPROM_SIZE exist in over 40 of them?
Because there are a lot of different AVR microcontrollers.
There was a problem hiding this comment.
I'd really love to find a way to avoid packaging all of these files in this repo but I'm at a loss for how to do so (while enabling a non-AVR compiler to supply all the #define statements some alternate way).
There was a problem hiding this comment.
Because there are a lot of different AVR microcontrollers.
But why isn't it defined for Mega2560? That microcontroller has EPROM in it. I was hoping that the macro would be a reliable way to determine whether the feature is present. Instead it seems that it has __EEPROM_REG_LOCATIONS__ but not the size.
There was a problem hiding this comment.
The files are mostly out of the way and don't bother me much; I just find myself expecting more of them than I should given my limited knowledge!
There was a problem hiding this comment.
I notice that, while the megaAVR EEPROM library uses EEPROM_SIZE, the AVR EEPROM library uses E2END.
There was a problem hiding this comment.
I see now. The macros are artifacts of the implementation, not a way of giving information to clients of the library, and different implementations will have different macros. That makes sense and is reasonable.
Further investigation shows that E2END exists in 230 files and many times is (0x0). Perhaps it is a more reliable macro to use.
|
@matthijskooijman will it make #144 difficult if I merge this one first? |
|
Understood, let me know when you have all your desired commits in and I'll squash & merge. |
|
I think this is ready to be merged into |
|
@ianfixes, This is ready to be merged into |
Previously we had a hard-coded size that assumed all boards has EEPROM. This defines it only for select boards and I'm adding Mega to that list.