Fixes after code-review

Author: ianton-ru

src/Parsers/FunctionSecretArgumentsFinder.h

@@ -93,15 +93,15 @@ class FunctionSecretArgumentsFinder
     {
         if (index >= function->arguments->size())
             return;
-        index = function->arguments->getRealIndex(index);
+        auto real_index = function->arguments->getRealIndex(index);
         if (!result.count)
         {
-            result.start = index;
+            result.start = real_index;
             result.are_named = argument_is_named;
         }
-        chassert(index >= result.start); /// We always check arguments consecutively
+        chassert(real_index >= result.start); /// We always check arguments consecutively
         chassert(result.replacement.empty()); /// We shouldn't use replacement with masking other arguments
-        result.count = index + 1 - result.start;
+        result.count = real_index + 1 - result.start;
         if (!argument_is_named)
             result.are_named = false;
     }

src/Storages/ObjectStorage/DataLakes/DataLakeConfiguration.h

@@ -146,7 +146,7 @@ class DataLakeConfiguration : public BaseStorageConfiguration, public std::enabl
 };
 
 #if USE_AVRO
-#if USE_AWS_S3
+#    if USE_AWS_S3
 using StorageS3IcebergConfiguration = DataLakeConfiguration<StorageS3Configuration, IcebergMetadata>;
 #    endif
 
@@ -160,7 +160,8 @@ using StorageHDFSIcebergConfiguration = DataLakeConfiguration<StorageHDFSConfigu
 
 using StorageLocalIcebergConfiguration = DataLakeConfiguration<StorageLocalConfiguration, IcebergMetadata>;
 
-
+/// Class detects storage type by `storage_type` parameter if exists
+/// and uses appropriate implementation - S3, Azure, HDFS or Local
 class StorageIcebergConfiguration : public StorageObjectStorage::Configuration, public std::enable_shared_from_this<StorageObjectStorage::Configuration>
 {
     friend class StorageObjectStorage::Configuration;
@@ -291,7 +292,7 @@ class StorageIcebergConfiguration : public StorageObjectStorage::Configuration,
                     {
                         throw Exception(
                             ErrorCodes::BAD_ARGUMENTS,
-                            "DataLake can have only one key-value argument: storage_type=().");
+                            "DataLake can have only one key-value argument: storage_type='type'.");
                     }
 
                     auto value = type_ast_function->arguments->children[1]->as<ASTLiteral>();
@@ -300,14 +301,14 @@ class StorageIcebergConfiguration : public StorageObjectStorage::Configuration,
                     {
                         throw Exception(
                             ErrorCodes::BAD_ARGUMENTS,
-                            "DataLake parameter 'storage_type' has wrong type.");
+                            "DataLake parameter 'storage_type' has wrong type, string literal expected.");
                     }
 
                     if (value->value.getType() != Field::Types::String)
                     {
                         throw Exception(
                             ErrorCodes::BAD_ARGUMENTS,
-                            "DataLake parameter 'storage_type' has wrong value type.");
+                            "DataLake parameter 'storage_type' has wrong value type, string expected.");
                     }
 
                     type = objectStorageTypeFromString(value->value.safeGet<String>());