fix: avoid jumping scroll position when upper item size is calculated #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akryum
reviewed
Apr 1, 2020
Owner
|
Won't this cause issues on touchscreens or touchpads with acceleration? |
Co-Authored-By: Guillaume Chau <[email protected]>
Contributor
Author
|
There seems to be no problem on acceleration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #248
fix #248 (comment)
The original issue that #248 tried to solve is already solved on the current master branch but there still is an issue when upper items are loaded.
In the case the current scroll position is bottom and scrolling up, the upper items will be loaded and their size will be set lazily. When the size is set to concrete value, the remaining items will be pushed for bottom, then scroll looks jumpy.
To avoid this, I'm comparing prev and next height of items and add the offset to scrollTop.