Test ocmmit #2
Closed
Test ocmmit #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamRJensen
added a commit
that referenced
this pull request
Dec 20, 2023
* prototype (#1) * first iteration * dynamic period * docstring * feedback * linting * Update pvlib/iotools/solcast.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Cliff Hansen <[email protected]> * midpoint docstring * flak8 formatting * PR 1875 (#2) * kandersolar feedback (#3) * addressing feedback from Kandersolar * Review (#4) added hack for ISO periods in Pandas 0.25 and clearsky parameter maps * comment on pandas version * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Adams's feedback * Update pvlib/iotools/solcast.py Co-authored-by: Adam R. Jensen <[email protected]> * Adams's feedback * Last minor changes * added test for _get_solcast * feat: add additional test coverage (#5) Co-authored-by: Hugh Cutcher <[email protected]> * linting --------- Co-authored-by: Cliff Hansen <[email protected]> Co-authored-by: Adam R. Jensen <[email protected]> Co-authored-by: hugh-solcast <[email protected]> Co-authored-by: Hugh Cutcher <[email protected]>
AdamRJensen
commented
Oct 19, 2024
AdamRJensen
commented
Oct 19, 2024
AdamRJensen
commented
Oct 19, 2024
AdamRJensen
commented
Oct 19, 2024
AdamRJensen
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Update variables_style_rules.csv * Update v0.11.2.rst * not sure what happened here after merge with main * Update v0.11.2.rst * update whatsnew and glossary page * Update spectrl2.py * Update irradiance.py * typo * update spectrl2.py and spectrum irradiance.py * grammar -- periods before/after units(?) * Apply suggestions from code review Co-authored-by: Kevin Anderson <[email protected]> * Update v0.11.2.rst * fix whatsnew formatting * formatting attempt #2 --------- Co-authored-by: Kevin Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.