all.sh: Fix check_headers_in_cpp #2407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When all.sh invokes check_headers_in_cpp, a backup config.h exists. This causes a stray difference vs cpp_dummy_build.cpp. Fix by only collecting the *.h files in include/mbedtls. Change-Id: Ifd415027e856858579a6699538f06fc49c793570
4 tasks
RonEld
added
bug
CLA valid
needs-review
RonEld
suggested changes
Feb 3, 2019
Contributor
RonEld
left a comment
RonEld
left a comment
There was a problem hiding this comment.
Code LGTM, however a ChangeLog entry is needed
pkolbus
force-pushed
the
fix-cpp-check-headers
branch
from
23a355c to
995d5c1
Compare
mpg
approved these changes
Feb 4, 2019
Contributor
mpg
left a comment
mpg
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for fixing this.
mpg
removed
the
needs-review
Contributor
|
Note: I've taken the liberty of editing the PR description regarding backporting, which happens not to be needed here. |
Contributor
|
This has two approving reviews and a passing CI, a valid CLA, fixes a legitimate bug with an appropriate ChangeLog entry and is not waiting for backports, so labeling as ready for merge. |
mpg
added
the
approved
Contributor
|
This PR didn't apply cleanly on mbedtls-2.16, so I've raised a backport PR at #2412 Please review. Thanks. |
Patater
added
the
needs-backports
Contributor
Author
mpg
removed
the
needs-backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When all.sh invokes check_headers_in_cpp, a backup config.h exists. This
causes a stray difference vs cpp_dummy_build.cpp. Fix by only collecting
the *.h files in include/mbedtls.
Fixes #2406.
Status
READY
Requires Backporting
[edited by mpg]
Migrations
If there is any API change, what's the incentive and logic for it.
NO
Additional comments
Any additional information that could be of interest
Todos
Steps to test or reproduce
./tests/scripts/all.sh build_default_make_gcc_and_cxx