Apply suggestions from code review

rajkan01 · LDong-Arm · web-flow · commit cc0eb22447af · 2020-07-22T19:55:40.000+01:00
Commit the reviewer suggestions

Co-authored-by: Lingkai Dong &lt;lingkai.dong@arm.com&gt;
diff --git a/UNITTESTS/features/cellular/framework/AT/at_cellularcontext/unittest.cmake b/UNITTESTS/features/cellular/framework/AT/at_cellularcontext/unittest.cmake
@@ -9,7 +9,6 @@ set(unittest-includes ${unittest-includes}
   ../features/cellular/framework/common
   ../features/cellular/framework/AT
   ../features/cellular/framework/device
-  ../features/cellular
 )
 
 # Source files
diff --git a/UNITTESTS/features/cellular/framework/AT/at_cellulardevice/unittest.cmake b/UNITTESTS/features/cellular/framework/AT/at_cellulardevice/unittest.cmake
@@ -12,7 +12,6 @@ set(unittest-includes ${unittest-includes}
   ../features/frameworks/mbed-client-randlib/mbed-client-randlib
   ../drivers
   ../hal
-  ../features/cellular
 )
 
 # Source files
@@ -60,4 +59,3 @@ set(unittest-test-flags
   -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
   -DMBED_CONF_CELLULAR_USE_SMS=1
 )
-
diff --git a/UNITTESTS/features/cellular/framework/AT/at_cellularinformation/unittest.cmake b/UNITTESTS/features/cellular/framework/AT/at_cellularinformation/unittest.cmake
@@ -9,7 +9,6 @@ set(unittest-includes ${unittest-includes}
   ../features/cellular/framework/common
   ../features/cellular/framework/AT
   ../features/frameworks/mbed-client-randlib/mbed-client-randlib
-  ../features/cellular
 )
 
 # Source files
diff --git a/UNITTESTS/features/cellular/framework/AT/at_cellularnetwork/unittest.cmake b/UNITTESTS/features/cellular/framework/AT/at_cellularnetwork/unittest.cmake
@@ -9,7 +9,6 @@ set(unittest-includes ${unittest-includes}
   ../features/cellular/framework/common
   ../features/cellular/framework/AT
   ../features/frameworks/mbed-client-randlib/mbed-client-randlib
-  ../features/cellular
 )
 
 # Source files
diff --git a/UNITTESTS/features/cellular/framework/AT/at_cellularsms/unittest.cmake b/UNITTESTS/features/cellular/framework/AT/at_cellularsms/unittest.cmake
@@ -9,7 +9,6 @@ set(unittest-includes ${unittest-includes}
   ../features/cellular/framework/common
   ../features/cellular/framework/AT
   ../features/frameworks/mbed-client-randlib/mbed-client-randlib
-  ../features/cellular
 )
 
 # Source files
diff --git a/UNITTESTS/features/cellular/framework/AT/at_cellularstack/unittest.cmake b/UNITTESTS/features/cellular/framework/AT/at_cellularstack/unittest.cmake
@@ -9,7 +9,6 @@ set(unittest-includes ${unittest-includes}
   ../features/cellular/framework/common
   ../features/cellular/framework/AT
   ../features/frameworks/mbed-client-randlib/mbed-client-randlib
-  ../features/cellular
 )
 
 # Source files
@@ -51,4 +50,3 @@ set(unittest-test-flags
   -DDEVICE_INTERRUPTIN=1
   -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
 )
-
diff --git a/UNITTESTS/features/cellular/framework/device/cellularcontext/unittest.cmake b/UNITTESTS/features/cellular/framework/device/cellularcontext/unittest.cmake
@@ -8,7 +8,6 @@ set(unittest-includes ${unittest-includes}
     /features/cellular/framework/device/cellulardevice
   ../features/cellular/framework/device
   ../features/cellular/framework/common
-  ../features/cellular
 )
 
 # Source files
diff --git a/UNITTESTS/features/cellular/framework/device/cellulardevice/unittest.cmake b/UNITTESTS/features/cellular/framework/device/cellulardevice/unittest.cmake
@@ -8,7 +8,6 @@ set(unittest-includes ${unittest-includes}
     /features/cellular/framework/device/cellulardevice
   ../features/cellular/framework/device
   ../features/cellular/framework/common
-  ../features/cellular
 )
 
 # Source files
@@ -49,4 +48,3 @@ set(unittest-test-flags
   -DDEVICE_SERIAL=1
   -DDEVICE_INTERRUPTIN=1
 )
-
diff --git a/UNITTESTS/features/cellular/framework/device/cellularstatemachine/unittest.cmake b/UNITTESTS/features/cellular/framework/device/cellularstatemachine/unittest.cmake
@@ -8,7 +8,6 @@ set(unittest-includes ${unittest-includes}
     /features/cellular/framework/device/cellularstatemachine
   ../features/cellular/framework/device
   ../features/cellular/framework/common
-  ../features/cellular
 )
 
 # Source files
diff --git a/connectivity/netsocket/tests/UNITTESTS/netsocket/CellularNonIPSocket/unittest.cmake b/connectivity/netsocket/tests/UNITTESTS/netsocket/CellularNonIPSocket/unittest.cmake
@@ -5,7 +5,6 @@
 
 # Add test specific include paths
 set(unittest-includes ${unittest-includes}
-  ../features/cellular
 )
 
 set(unittest-sources

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@ set(unittest-includes ${unittest-includes}`
`9`	`9`	`../features/cellular/framework/common`
`10`	`10`	`../features/cellular/framework/AT`
`11`	`11`	`../features/cellular/framework/device`
`12`		`- ../features/cellular`
`13`	`12`	`)`
`14`	`13`
`15`	`14`	`# Source files`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,6 @@ set(unittest-includes ${unittest-includes}`
`12`	`12`	`../features/frameworks/mbed-client-randlib/mbed-client-randlib`
`13`	`13`	`../drivers`
`14`	`14`	`../hal`
`15`		`- ../features/cellular`
`16`	`15`	`)`
`17`	`16`
`18`	`17`	`# Source files`
`@@ -60,4 +59,3 @@ set(unittest-test-flags`
`60`	`59`	`-DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200`
`61`	`60`	`-DMBED_CONF_CELLULAR_USE_SMS=1`
`62`	`61`	`)`
`63`		`-`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ set(unittest-includes ${unittest-includes}`
`8`	`8`	`/features/cellular/framework/device/cellulardevice`
`9`	`9`	`../features/cellular/framework/device`
`10`	`10`	`../features/cellular/framework/common`
`11`		`- ../features/cellular`
`12`	`11`	`)`
`13`	`12`
`14`	`13`	`# Source files`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@`
`5`	`5`
`6`	`6`	`# Add test specific include paths`
`7`	`7`	`set(unittest-includes ${unittest-includes}`
`8`		`- ../features/cellular`
`9`	`8`	`)`
`10`	`9`
`11`	`10`	`set(unittest-sources`