Skip to content

Commit c9d7f94

Browse files
Add issue numbers for some missing parts of secure element support
1 parent 5da7b3e commit c9d7f94

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

library/psa_crypto.c

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1214,8 +1214,10 @@ psa_status_t psa_get_key_attributes( psa_key_handle_t handle,
12141214
case PSA_KEY_TYPE_RSA_KEY_PAIR:
12151215
case PSA_KEY_TYPE_RSA_PUBLIC_KEY:
12161216
#if defined(MBEDTLS_PSA_CRYPTO_SE_C)
1217-
/* TOnogrepDO: reporting the public exponent for opaque keys
1218-
* is not yet implemented. */
1217+
/* TODO: reporting the public exponent for opaque keys
1218+
* is not yet implemented.
1219+
* https://github.com/ARMmbed/mbed-crypto/issues/216
1220+
*/
12191221
if( psa_key_slot_is_external( slot ) )
12201222
break;
12211223
#endif /* MBEDTLS_PSA_CRYPTO_SE_C */
@@ -1735,10 +1737,12 @@ static void psa_fail_key_creation( psa_key_slot_t *slot,
17351737
return;
17361738

17371739
#if defined(MBEDTLS_PSA_CRYPTO_SE_C)
1738-
/* TOnogrepDO: If the key has already been created in the secure
1740+
/* TODO: If the key has already been created in the secure
17391741
* element, and the failure happened later (when saving metadata
17401742
* to internal storage), we need to destroy the key in the secure
1741-
* element. */
1743+
* element.
1744+
* https://github.com/ARMmbed/mbed-crypto/issues/217
1745+
*/
17421746

17431747
/* Abort the ongoing transaction if any (there may not be one if
17441748
* the creation process failed before starting one, or if the
@@ -6088,8 +6092,10 @@ static psa_status_t psa_crypto_recover_transaction(
60886092
{
60896093
case PSA_CRYPTO_TRANSACTION_CREATE_KEY:
60906094
case PSA_CRYPTO_TRANSACTION_DESTROY_KEY:
6091-
/* TOnogrepDO - fall through to the failure case until this
6092-
* is implemented */
6095+
/* TODO - fall through to the failure case until this
6096+
* is implemented.
6097+
* https://github.com/ARMmbed/mbed-crypto/issues/218
6098+
*/
60936099
default:
60946100
/* We found an unsupported transaction in the storage.
60956101
* We don't know what state the storage is in. Give up. */

0 commit comments

Comments
 (0)