Skip to content

Commit 4b13ee7

Browse files
douglas-raillard-armmarcbonnici
authored andcommitted
ftrace: Avoid repeated available events query
FtraceCollector.available_events is not memoized anymore as the set of events supported by the target can change dynamically (e.g. loading a kernel module). This means that calling self.available_events is somewhat expensive, so avoid doing it in a loop. Instead, save the events in a variable and reuse it in the function to save a substantial amount of time.
1 parent fade6b4 commit 4b13ee7

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

devlib/collector/ftrace.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,11 @@ def event_is_in_list(event, events):
137137
for _event in events
138138
)
139139

140+
available_events = self.available_events
140141
unavailable_events = [
141142
event
142143
for event in self.events
143-
if not event_is_in_list(event, self.available_events)
144+
if not event_is_in_list(event, available_events)
144145
]
145146
if unavailable_events:
146147
message = 'Events not available for tracing: {}'.format(

0 commit comments

Comments
 (0)