Add Alpha support for SME2 #217

sdesmalen-arm · 2022-10-06T16:49:26Z

This patch adds new intrinsics and types for supporting SME2.

name: Pull request
about: Feature proposal.

Thank you for submitting a pull request!

If this PR is about a bugfix:

Please use the bugfix label and make sure to go through the checklist below.

If this PR is about a proposal:

We are looking forward to evaluate your proposal, and if possible to
make it part of the Arm C Language Extension (ACLE) specifications.

We would like to encourage you reading through the contribution
guidelines, in particular the section on submitting
a proposal.

Please use the proposal label.

As for any pull request, please make sure to go through the below
checklist.

Checklist: (mark with X those which apply)

If an issue reporting the bug exists, I have mentioned it in the
PR (do not bother creating the issue if all you want to do is
fixing the bug yourself).
I have added/updated the SPDX-FileCopyrightText lines on top
of any file I have edited. Format is SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>
(Please update existing copyright lines if applicable. You can
specify year ranges with hyphen , as in 2017-2019, and use
commas to separate gaps, as in 2018-2020, 2022).
I have updated the Copyright section of the sources of the
specification I have edited (this will show up in the text
rendered in the PDF and other output format supported). The
format is the same described in the previous item.
I have run the CI scripts (if applicable, as they might be
tricky to set up on non-*nix machines). The sequence can be
found in the contribution
guidelines. Don't
worry if you cannot run these scripts on your machine, your
patch will be automatically checked in the Actions of the pull
request.
I have added an item that describes the changes I have
introduced in this PR in the section Changes for next
release of the section Change Control/Document history
of the document. Create Changes for next release if it does
not exist. Notice that changes that are not modifying the
content and rendering of the specifications (both HTML and PDF)
do not need to be listed.
When modifying content and/or its rendering, I have checked the
correctness of the result in the PDF output (please refer to the
instructions on how to build the PDFs
locally).
The variable draftversion is set to true in the YAML header
of the sources of the specifications I have modified.
Please DO NOT add my GitHub profile to the list of contributors
in the README page of the project.

This patch adds new intrinsics and types for supporting SME2.

rsandifo-arm

Looks great. I haven't looked in detail at each individual intrinsic — the actual implementation seems like the best way of doing that — but I've added some comments based on a comparison with SVE.

main/acle.md

* Addressed suggestions in descriptions * Removed unnecessary newlines * Merged optional suffixes e.g. `[_single][_u16][_x2]` -> `[_single_u16_x2]` * Renamed svuqrshr -> svqrshr (the signedness can be deduced form the operands and there wasn't a svsqrshr either for SQRSHR) * Replaced `enum sv_vgkind` by `uint64_t` immediate. * Generalised `imm_1_8` into `imm` since this immediate wasn't correct for all types.

… squash]

main/acle.md

The C and C++ Language Extensions for AArch64 SME2 [1] adds a new type called `svcount_t` which describes a predicate. This is not a predicate vector mask, but rather a description of a predicate vector mask that can be expanded into a mask using explicit instructions. The type is a scalable opaque type. To implement `svcount_t` type this patch uses the existing Target Extension Type mechanism, but adds further support so that this type can be a scalable type. AArch64 CodeGen support will follow in a separate patch. [1] ARM-software/acle#217 Reviewed By: jcranmer-intel, nikic Differential Revision: https://reviews.llvm.org/D136861

The 'l' is redundant because of the `_za32` or `_za64` suffixes already present in the function prototype, from which the 'long' or 'long long' can be deduced.

…ns [to squash]

This avoids a name clash with SVE intrinsics for svmlslb_f32/svmlslt_f32, and also aligns with what was done with bfmlalb/bfmlalt for SVE.

For _za8, the tile can only be '0', hence the reason why the tile wasn't explicitly passed in. But there are overloaded forms for _za16, _za32, _za64 and _za128 that do require a tile, so this change adds the tile operand to all intrinsics. For _za8, it is up to the compiler to ensure that no value other than '0' can be passed.

The return type cannot be deduced from one of the operands, so must be explicitly specified in the name of the intrinsic.

…ngle [to squash]

The following SME2 intrinsic: svint32_t svdot[_s32](svint32_t, svint8_t, svint8_t); clashes with the one we defined for SME2: svint32_t svdot[_s32](svint32_t, svint16_t, svint16_t); This patch renames these to: svint32_t svdot[_s32_s16_s16]((svint32_t, svint16_t, svint16_t); which is unambiguous and allows for the possibility of retroactively updating the SVE intrinsics to have a similar name (svdot[_s32_s8_s8]).

main/acle.md

The PSEL and PFALSE instructions have aliases to accept a predicate-as-counter register. It makes sense to add corresponding ACLE intrinsics for user convenience.

main/acle.md

Also fixed a use of `svread_hor_za8` in the description of _vg2/_vg4 where it was missing the newly added tile operand.

Adds the following SME2 builtins: - svmop(a|s)_za32, - svbmop(a|s)_za32 See ARM-software/acle#217

) Adds the following SME2 builtins: - svmop(a|s)_za32, - svbmop(a|s)_za32 See ARM-software/acle#217

See ARM-software/acle#217 Patch by: Kerry McLaughlin [email protected]

See ARM-software/acle#217 Patch by: Hassnaa Hamdi <[email protected]>

Adds builtins for: - FCVT - BFCVT - FCVTZS - FCVTZU - SCVTF - UCVTF - BFCVTN - FCVTN - SQCVT - SQCVTU - UQCVT - SQCVTN - SQCVTUN - UQCVTN See ARM-software/acle#217

Adds the following SME2 builtins: - svread_hor/ver, - svwrite_hor/ver, - svread_za64, - svwrite_za64 See ARM-software/acle#217

See ARM-software/acle#217 Patch by: Hassnaa Hamdi <[email protected]>

This patch adds new intrinsics and types for supporting SME2.

See ARM-software/acle#217 Patch by: Hassnaa Hamdi <[email protected]>

Adds builtins for: - FCVT - BFCVT - FCVTZS - FCVTZU - SCVTF - UCVTF - BFCVTN - FCVTN - SQCVT - SQCVTU - UQCVT - SQCVTN - SQCVTUN - UQCVTN See ARM-software/acle#217

See ARM-software/acle#217 Patch by: Hassnaa Hamdi <[email protected]>

Extend pfalse and ptrue builtins with svcount_t return types to be enabled for sve2p1 and sme2 See ARM-software/acle#217

Adds the following SME2 builtins: - svread_hor/ver, - svwrite_hor/ver, - svread_za64, - svwrite_za64 See ARM-software/acle#217

sallyarmneale · 2024-03-25T16:44:27Z

main/acle.md

+ZA array vectors. The intrinsics model this in the following way:
+
+*   Multi-vector operands are groups of SVE data vectors, that use the same
+    tuple types as defined in the [SVE ACLE](#sve-vector-types), e.g.


Avoid Latin contractions.
e.g. -> for example.

sallyarmneale

Avoid all latin contractions:
e.g. -> For example
i.e. -> that is
etc. -> and so on

Adds the following SME2 builtins: - svread_hor/ver, - svwrite_hor/ver, - svread_za64, - svwrite_za64 See ARM-software/acle#217

These intrinsics are used to implement the sel intrinsics that selects a tuple of 2 or 4 values based on a predicate-as-counter operand, e.g. __attribute__((arm_streaming)) svuint8x2_t svsel[_u8_x2](svcount_t png, svuint8x2_t zn, svuint8x2_t zm); __attribute__((arm_streaming)) svuint8x4_t svsel[_u8_x4](svcount_t png, svuint8x4_t zn, svuint8x4_t zm); As described in ARM-software/acle#217 Reviewed By: CarolineConcatto Differential Revision: https://reviews.llvm.org/D150951

…nt1/st1/stnt1 These intrinsics are used to implement multi-vector load/store intrinsics that loads or stores a tuple of 2 or 4 values, based on a predicate-as-counter operand, e.g. __attribute__((arm_streaming)) svuint8x2_t svld1[_u8]_x2(svcount_t png, const uint8_t *rn); __attribute__((arm_streaming)) void svst1[_u8_x2](svcount_t png, uint8_t *rn, svuint8x2_t zt); As described in ARM-software/acle#217 Reviewed By: CarolineConcatto Differential Revision: https://reviews.llvm.org/D150956

Add Alpha support for SME2

30dee02

This patch adds new intrinsics and types for supporting SME2.

rsandifo-arm reviewed Oct 7, 2022

View reviewed changes

main/acle.md Outdated Show resolved Hide resolved

TNorthover reviewed Oct 28, 2022

View reviewed changes

main/acle.md Outdated Show resolved Hide resolved

kmclaughlin-arm reviewed Oct 28, 2022

View reviewed changes

main/acle.md Outdated Show resolved Hide resolved

david-arm reviewed Nov 3, 2022

View reviewed changes

main/acle.md Show resolved Hide resolved

david-arm reviewed Nov 4, 2022

View reviewed changes

main/acle.md Show resolved Hide resolved

main/acle.md Outdated Show resolved Hide resolved

kmclaughlin-arm reviewed Nov 9, 2022

View reviewed changes

main/acle.md Outdated Show resolved Hide resolved

sdesmalen-arm added 2 commits November 10, 2022 17:17

Address a few more review comments I missed in the previous patch [to…

ae149ed

… squash]

CarolineConcatto reviewed Nov 17, 2022

View reviewed changes

main/acle.md Outdated Show resolved Hide resolved

david-arm reviewed Nov 21, 2022

View reviewed changes

main/acle.md Outdated Show resolved Hide resolved

david-arm reviewed Nov 24, 2022

View reviewed changes

main/acle.md Outdated Show resolved Hide resolved

CarolineConcatto reviewed Dec 13, 2022

View reviewed changes

main/acle.md Show resolved Hide resolved

kmclaughlin-arm reviewed Dec 14, 2022

View reviewed changes

main/acle.md Outdated Show resolved Hide resolved

vhscampos added the proposal label Feb 21, 2023

sdesmalen-arm added 7 commits March 28, 2023 11:24

Remove trailing 'l' from svmlal/mlsl intrinsics [to squash]

b61ff70

The 'l' is redundant because of the `_za32` or `_za64` suffixes already present in the function prototype, from which the 'long' or 'long long' can be deduced.

Clarify the value of 'vl' operand for predicate-as-counter instructio…

47ca61f

…ns [to squash]

Rename svmlslb -> sbfmlslb and svmlslt ->svbfmlslt [to squash]

3b8a6e7

This avoids a name clash with SVE intrinsics for svmlslb_f32/svmlslt_f32, and also aligns with what was done with bfmlalb/bfmlalt for SVE.

Type suffix in svread_za64[_s64] cannot be optional [to squash]

1559773

The return type cannot be deduced from one of the operands, so must be explicitly specified in the name of the intrinsic.

Fix the suffix for svusdot/svsudot to be consistent between _lane/_si…

3e39320

…ngle [to squash]

CarolineConcatto reviewed Apr 17, 2023

View reviewed changes

main/acle.md Outdated Show resolved Hide resolved

CarolineConcatto reviewed Apr 17, 2023

View reviewed changes

main/acle.md Show resolved Hide resolved

CarolineConcatto reviewed Apr 17, 2023

View reviewed changes

main/acle.md Show resolved Hide resolved

Add svcount_t forms for psel and pfalse intrinsics.

85f22ec

The PSEL and PFALSE instructions have aliases to accept a predicate-as-counter register. It makes sense to add corresponding ACLE intrinsics for user convenience.

CarolineConcatto reviewed Apr 28, 2023

View reviewed changes

main/acle.md Outdated Show resolved Hide resolved

Cleanup, removed intrinsics that were added in SME [to squash]

18c5da2

Also fixed a use of `svread_hor_za8` in the description of _vg2/_vg4 where it was missing the newly added tile operand.

MDevereau mentioned this pull request Nov 24, 2023

[SME2] Add LUTI2 and LUTI4 quad Builtins and Intrinsics llvm/llvm-project#73317

Merged

kmclaughlin-arm added a commit to kmclaughlin-arm/llvm-project that referenced this pull request Nov 24, 2023

[Clang][SME2] Add outer product and accumulate/subtract builtins

c975abe

Adds the following SME2 builtins: - svmop(a|s)_za32, - svbmop(a|s)_za32 See ARM-software/acle#217

kmclaughlin-arm added a commit to llvm/llvm-project that referenced this pull request Nov 27, 2023

[Clang][SME2] Add outer product and accumulate/subtract builtins (#71176

d1652ff

) Adds the following SME2 builtins: - svmop(a|s)_za32, - svbmop(a|s)_za32 See ARM-software/acle#217

MDevereau added a commit to llvm/llvm-project that referenced this pull request Dec 1, 2023

[AArch64][SME2] Add SME2 builtins for zero { zt0 } (#72274)

e59a0cd

See ARM-software/acle#217 Patch by: Kerry McLaughlin [email protected]

MDevereau added a commit to MDevereau/llvm-project that referenced this pull request Dec 4, 2023

[SME2] Add LUTI2 and LUTI4 quad Builtins and Intrinsics

c3ae3c6

See ARM-software/acle#217 Patch by: Hassnaa Hamdi <[email protected]>

MDevereau mentioned this pull request Dec 5, 2023

[AArch64][SME2] Add multi-vector builtins for cvt llvm/llvm-project#74450

Merged

MDevereau added a commit to llvm/llvm-project that referenced this pull request Dec 6, 2023

[SME2] Add LUTI2 and LUTI4 quad Builtins and Intrinsics (#73317)

6704d6a

See ARM-software/acle#217 Patch by: Hassnaa Hamdi <[email protected]>

CarolineConcatto pushed a commit to CarolineConcatto/acle that referenced this pull request Dec 6, 2023

Add Alpha support for SME2 (ARM-software#217)

9dd4a0e

This patch adds new intrinsics and types for supporting SME2.

MDevereau added a commit to MDevereau/llvm-project that referenced this pull request Dec 6, 2023

[SME2] Add LUTI2 and LUTI4 double Builtins and Intrinsics

83b36bc

See ARM-software/acle#217 Patch by: Hassnaa Hamdi <[email protected]>

MDevereau added a commit to MDevereau/llvm-project that referenced this pull request Dec 6, 2023

[SME2] Add LUTI2 and LUTI4 single Builtins and Intrinsics

aaf7270

See ARM-software/acle#217 Patch by: Hassnaa Hamdi <[email protected]>

MDevereau added a commit to llvm/llvm-project that referenced this pull request Dec 6, 2023

[SME2] Add LUTI2 and LUTI4 double Builtins and Intrinsics (#73305)

30faf19

See ARM-software/acle#217 Patch by: Hassnaa Hamdi <[email protected]>

MDevereau added a commit to llvm/llvm-project that referenced this pull request Dec 6, 2023

[SME2] Add LUTI2 and LUTI4 single Builtins and Intrinsics (#73304)

8186e15

See ARM-software/acle#217 Patch by: Hassnaa Hamdi <[email protected]>

MDevereau added a commit to llvm/llvm-project that referenced this pull request Dec 6, 2023

Add SME2 builtins for pfalse and ptrue (#71953)

2f62037

Extend pfalse and ptrue builtins with svcount_t return types to be enabled for sve2p1 and sme2 See ARM-software/acle#217

sallyarmneale reviewed Mar 25, 2024

View reviewed changes

Add Alpha support for SME2 #217

Add Alpha support for SME2 #217

Uh oh!

Conversation

sdesmalen-arm commented Oct 6, 2022

Uh oh!

rsandifo-arm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sallyarmneale Mar 25, 2024

Choose a reason for hiding this comment

Uh oh!

sallyarmneale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!