fix authcode tests

Author: patrislav

packages/wallet/wdk/test/authcode-pkce.test.ts

@@ -56,6 +56,7 @@ describe('AuthCodePkceHandler', () => {
     handler = new AuthCodePkceHandler(
       'google-pkce',
       'https://accounts.google.com',
+      'https://accounts.google.com/o/oauth2/v2/auth',
       'test-google-client-id',
       mockNitroInstrument,
       mockSignatures,
@@ -81,8 +82,6 @@ describe('AuthCodePkceHandler', () => {
         email: '[email protected]',
       }
     })
-
-    vi.spyOn(handler as any, 'oauthUrl').mockReturnValue('https://accounts.google.com/oauth/authorize')
   })
 
   afterEach(() => {
@@ -116,7 +115,7 @@ describe('AuthCodePkceHandler', () => {
       })
 
       // Verify OAuth URL is constructed correctly
-      expect(result).toMatch(/^https:\/\/accounts\.google\.com\/oauth\/authorize\?/)
+      expect(result).toMatch(/^https:\/\/accounts\.google\.com\/o\/oauth2\/v2\/auth\?/)
       expect(result).toContain('code_challenge=mock-challenge-hash')
       expect(result).toContain('code_challenge_method=S256')
       expect(result).toContain('client_id=test-google-client-id')
@@ -335,19 +334,16 @@ describe('AuthCodePkceHandler', () => {
       const newRedirectUri = 'https://newdomain.com/callback'
       handler.setRedirectUri(newRedirectUri)
 
-      // Verify redirect URI is used in OAuth URL construction
-      const mockUrl = 'https://accounts.google.com/oauth/authorize'
-      vi.spyOn(handler as any, 'oauthUrl').mockReturnValue(mockUrl)
-
       return handler.commitAuth('https://example.com/success', true).then((result) => {
         expect(result).toContain(`redirect_uri=${encodeURIComponent(newRedirectUri)}`)
       })
     })
 
     it('Should work with different issuer and audience configurations', () => {
       const customHandler = new AuthCodePkceHandler(
-        'google-pkce',
+        'custom-provider',
         'https://custom-issuer.com',
+        'https://custom-issuer.com/o/oauth2/v2/auth',
         'custom-client-id',
         mockNitroInstrument,
         mockSignatures,
@@ -357,7 +353,7 @@ describe('AuthCodePkceHandler', () => {
 
       expect(customHandler['issuer']).toBe('https://custom-issuer.com')
       expect(customHandler['audience']).toBe('custom-client-id')
-      expect(customHandler.signupKind).toBe('google-pkce')
+      expect(customHandler.signupKind).toBe('custom-provider')
     })
   })
 })

packages/wallet/wdk/test/authcode.test.ts

@@ -129,6 +129,7 @@ describe('AuthCodeHandler', () => {
     authCodeHandler = new AuthCodeHandler(
       'google-pkce',
       'https://accounts.google.com',
+      'https://accounts.google.com/o/oauth2/v2/auth',
       'test-audience',
       mockIdentityInstrument,
       mockSignatures,
@@ -148,6 +149,7 @@ describe('AuthCodeHandler', () => {
       const handler = new AuthCodeHandler(
         'google-pkce',
         'https://accounts.google.com',
+        'https://accounts.google.com/o/oauth2/v2/auth',
         'google-client-id',
         mockIdentityInstrument,
         mockSignatures,
@@ -165,6 +167,7 @@ describe('AuthCodeHandler', () => {
       const handler = new AuthCodeHandler(
         'apple',
         'https://appleid.apple.com',
+        'https://appleid.apple.com/auth/authorize',
         'apple-client-id',
         mockIdentityInstrument,
         mockSignatures,
@@ -189,6 +192,7 @@ describe('AuthCodeHandler', () => {
       const googleHandler = new AuthCodeHandler(
         'google-pkce',
         'https://accounts.google.com',
+        'https://accounts.google.com/o/oauth2/v2/auth',
         'test-audience',
         mockIdentityInstrument,
         mockSignatures,
@@ -203,6 +207,7 @@ describe('AuthCodeHandler', () => {
       const appleHandler = new AuthCodeHandler(
         'apple',
         'https://appleid.apple.com',
+        'https://appleid.apple.com/auth/authorize',
         'test-audience',
         mockIdentityInstrument,
         mockSignatures,
@@ -293,6 +298,7 @@ describe('AuthCodeHandler', () => {
       const appleHandler = new AuthCodeHandler(
         'apple',
         'https://appleid.apple.com',
+        'https://appleid.apple.com/auth/authorize',
         'apple-client-id',
         mockIdentityInstrument,
         mockSignatures,
@@ -491,52 +497,40 @@ describe('AuthCodeHandler', () => {
     })
   })
 
-  // === OAUTH URL METHOD ===
+  // === OAUTH URL PROPERTY ===
 
-  describe('oauthUrl()', () => {
+  describe('oauthUrl', () => {
     it('Should return Google OAuth URL for Google issuer', () => {
       const googleHandler = new AuthCodeHandler(
         'google-pkce',
         'https://accounts.google.com',
+        'https://accounts.google.com/o/oauth2/v2/auth',
         'test-audience',
         mockIdentityInstrument,
         mockSignatures,
         mockAuthCommitments,
         mockAuthKeys,
       )
 
-      const url = googleHandler['oauthUrl']()
+      const url = googleHandler['oauthUrl']
       expect(url).toBe('https://accounts.google.com/o/oauth2/v2/auth')
     })
 
     it('Should return Apple OAuth URL for Apple issuer', () => {
       const appleHandler = new AuthCodeHandler(
         'apple',
         'https://appleid.apple.com',
+        'https://appleid.apple.com/auth/authorize',
         'test-audience',
         mockIdentityInstrument,
         mockSignatures,
         mockAuthCommitments,
         mockAuthKeys,
       )
 
-      const url = appleHandler['oauthUrl']()
+      const url = appleHandler['oauthUrl']
       expect(url).toBe('https://appleid.apple.com/auth/authorize')
     })
-
-    it('Should throw error for unsupported issuer', () => {
-      const unsupportedHandler = new AuthCodeHandler(
-        'google-pkce',
-        'https://unsupported.provider.com',
-        'test-audience',
-        mockIdentityInstrument,
-        mockSignatures,
-        mockAuthCommitments,
-        mockAuthKeys,
-      )
-
-      expect(() => unsupportedHandler['oauthUrl']()).toThrow('unsupported-issuer')
-    })
   })
 
   // === INHERITED METHODS FROM IDENTITYHANDLER ===
@@ -711,38 +705,6 @@ describe('AuthCodeHandler', () => {
       expect(metadata.email).toBe('[email protected]')
     })
 
-    it('Should handle different OAuth providers correctly', async () => {
-      const providers = [
-        {
-          signupKind: 'google-pkce' as const,
-          issuer: 'https://accounts.google.com',
-          expectedUrl: 'https://accounts.google.com/o/oauth2/v2/auth',
-        },
-        {
-          signupKind: 'apple' as const,
-          issuer: 'https://appleid.apple.com',
-          expectedUrl: 'https://appleid.apple.com/auth/authorize',
-        },
-      ]
-
-      for (const provider of providers) {
-        const handler = new AuthCodeHandler(
-          provider.signupKind,
-          provider.issuer,
-          'test-audience',
-          mockIdentityInstrument,
-          mockSignatures,
-          mockAuthCommitments,
-          mockAuthKeys,
-        )
-        handler.setRedirectUri('https://example.com/callback')
-
-        const url = await handler.commitAuth('/target', false)
-        expect(url).toContain(provider.expectedUrl)
-        expect(handler.kind).toBe(`login-${provider.signupKind}`)
-      }
-    })
-
     it('Should handle signup vs login flows correctly', async () => {
       authCodeHandler.setRedirectUri('https://example.com/callback')