Skip to content

Commit efa4a47

Browse files
committed
ci_view_test: minimal change TUI chars
Due to a minimal change in tview library an additional char was added when printing the stage and jobs to the terminal. Unfortunately these tests are too sensitive to this type of changes. My suggestion is that we remove visual tests from our code, since the library has their own tests and we should not be worried on how things are really printed. Signed-off-by: Bruno Meneguele <[email protected]>
1 parent 0dd35f5 commit efa4a47

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

cmd/ci_view_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -422,22 +422,22 @@ func Test_jobsView(t *testing.T) {
422422
" │ Stage1 │ │ Stage2 │ │ Stage3 │ ",
423423
" └────────────────────┘ └────────────────────┘ └────────────────────┘ ",
424424
" ",
425-
" ╔✔ stage1-job1-reall…╗ ┌───● stage2-job1───┐ ┌───● stage3-job1───┐ ",
425+
" ╔✔ stage1-job1-reall…╗ ┌───● stage2-job1───┐ ┌───● stage3-job1───┐ ",
426426
" ║ ║ │ │ │ │ ",
427427
" ║ 01m 01s║━┳━━┳━│ │━┳━━┳━│ │ ",
428428
" ╚════════════════════╝ ┃ ┃ └────────────────────┘ ┃ ┃ └────────────────────┘ ",
429429
" ┃ ┃ ┃ ┃ ",
430-
" ┌───✔ stage1-job2───┐ ┃ ┃ ┌───● stage2-job2───┐ ┃ ┃ ┌───● stage3-job2───┐ ",
430+
" ┌───✔ stage1-job2───┐ ┃ ┃ ┌───● stage2-job2───┐ ┃ ┃ ┌───● stage3-job2───┐ ",
431431
" │ │ ┃ ┃ │ │ ┃ ┃ │ │ ",
432432
" │ │━┫ ┣━│ │━┫ ┗━│ │ ",
433433
" └────────────────────┘ ┃ ┃ └────────────────────┘ ┃ └────────────────────┘ ",
434434
" ┃ ┃ ┃ ",
435-
" ┌───✔ stage1-job3───┐ ┃ ┃ ┌───● stage2-job3───┐ ┃ ",
435+
" ┌───✔ stage1-job3───┐ ┃ ┃ ┌───● stage2-job3───┐ ┃ ",
436436
" │ │ ┃ ┃ │ │ ┃ ",
437437
" │ │━┫ ┗━│ │━┛ ",
438438
" └────────────────────┘ ┃ └────────────────────┘ ",
439439
" ┃ ",
440-
" ┌───✘ stage1-job4───┐ ┃ ",
440+
" ┌───✘ stage1-job4───┐ ┃ ",
441441
" │ │ ┃ ",
442442
" │ │━┛ ",
443443
" └────────────────────┘ ",

0 commit comments

Comments
 (0)