Fix <use> referencing paths with no contents (#279)

edemaine · web-flow · commit 6f663a199b9f · 2023-12-11T10:11:56.000+01:00
Fixes #278
diff --git a/src/nodes/geometrynode.ts b/src/nodes/geometrynode.ts
@@ -80,7 +80,7 @@ export abstract class GeometryNode extends GraphicsNode {
 
   protected getBoundingBoxCore(context: Context): Rect {
     const path = this.getCachedPath(context)
-    if (!path) {
+    if (!path || !path.segments.length) {
       return [0, 0, 0, 0]
     }
     let minX = Number.POSITIVE_INFINITY
diff --git a/test/common/tests.js b/test/common/tests.js
@@ -55,6 +55,7 @@ window.tests = [
   'style-sheets',
   'svg-viewbox',
   'svg-use',
+  'svg-use-empty',
   'symbols',
   'text-fill-stroke',
   'text-placement',
diff --git a/test/specs/svg-use-empty/reference.pdf b/test/specs/svg-use-empty/reference.pdf
diff --git a/test/specs/svg-use-empty/spec.svg b/test/specs/svg-use-empty/spec.svg
@@ -0,0 +1,6 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 300 150">
+  <defs>
+    <path id="MJX-34-TEX-N-2061" d=""/>
+  </defs>
+  <use href="#MJX-34-TEX-N-2061" />
+</svg>

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ export abstract class GeometryNode extends GraphicsNode {`
`80`	`80`
`81`	`81`	`protected getBoundingBoxCore(context: Context): Rect {`
`82`	`82`	`const path = this.getCachedPath(context)`
`83`		`- if (!path) {`
	`83`	`+ if (!path \|\| !path.segments.length) {`
`84`	`84`	`return [0, 0, 0, 0]`
`85`	`85`	`}`
`86`	`86`	`let minX = Number.POSITIVE_INFINITY`