fix(synonyms): fix method signature of upserting synonym sets

Author: tharropoulos

src/typesense/synonym_set.py

@@ -9,10 +9,11 @@
 
 from typesense.api_call import ApiCall
 from typesense.types.synonym_set import (
+    SynonymItemDeleteSchema,
+    SynonymItemSchema,
+    SynonymSetCreateSchema,
     SynonymSetDeleteSchema,
     SynonymSetRetrieveSchema,
-    SynonymItemSchema,
-    SynonymItemDeleteSchema,
 )
 
 
@@ -35,13 +36,21 @@ def retrieve(self) -> SynonymSetRetrieveSchema:
         )
         return response
 
+    def upsert(self, set: SynonymSetCreateSchema) -> SynonymSetCreateSchema:
+        response: SynonymSetCreateSchema = self.api_call.put(
+            self._endpoint_path,
+            entity_type=SynonymSetCreateSchema,
+            body=set,
+        )
+        return response
+
     def delete(self) -> SynonymSetDeleteSchema:
         response: SynonymSetDeleteSchema = self.api_call.delete(
             self._endpoint_path,
             entity_type=SynonymSetDeleteSchema,
         )
         return response
-    
+
     @property
     def _items_path(self) -> str:
         return "/".join([self._endpoint_path, "items"])  # /synonym_sets/{name}/items
@@ -57,9 +66,7 @@ def list_items(
             "offset": offset,
         }
         clean_params: typing.Dict[str, int] = {
-            k: v
-            for k, v in params.items()
-            if v is not None
+            k: v for k, v in params.items() if v is not None
         }
         response: typing.List[SynonymItemSchema] = self.api_call.get(
             self._items_path,
@@ -91,5 +98,3 @@ def delete_item(self, item_id: str) -> SynonymItemDeleteSchema:
             "/".join([self._items_path, item_id]), entity_type=SynonymItemDeleteSchema
         )
         return response
-
-

src/typesense/synonym_sets.py

@@ -10,7 +10,6 @@
 from typesense.api_call import ApiCall
 from typesense.synonym_set import SynonymSet
 from typesense.types.synonym_set import (
-    SynonymSetCreateSchema,
     SynonymSetSchema,
 )
 
@@ -33,15 +32,3 @@ def __getitem__(self, synonym_set_name: str) -> SynonymSet:
         from typesense.synonym_set import SynonymSet as PerSet
 
         return PerSet(self.api_call, synonym_set_name)
-
-    def upsert(
-        self,
-        synonym_set_name: str,
-        payload: SynonymSetCreateSchema,
-    ) -> SynonymSetSchema:
-        response: SynonymSetSchema = self.api_call.put(
-            "/".join([SynonymSets.resource_path, synonym_set_name]),
-            body=payload,
-            entity_type=SynonymSetSchema,
-        )
-        return response

tests/synonym_sets_test.py

@@ -19,7 +19,6 @@
     SynonymSetSchema,
 )
 
-
 pytestmark = pytest.mark.skipif(
     not is_v30_or_above(
         Client(
@@ -102,7 +101,7 @@ def test_create(fake_synonym_sets: SynonymSets) -> None:
                 }
             ]
         }
-        fake_synonym_sets.upsert("test-set", payload)
+        fake_synonym_sets["test-set"].upsert(payload)
 
         assert mock.call_count == 1
         assert mock.called is True
@@ -116,8 +115,7 @@ def test_actual_create(
     delete_all_synonym_sets: None,
 ) -> None:
     """Test that the SynonymSets object can create a synonym set on Typesense Server."""
-    response = actual_synonym_sets.upsert(
-        "test-set",
+    response = actual_synonym_sets["test-set"].upsert(
         {
             "items": [
                 {