fix(abg): generate unique enum value names (#1936)

Author: Vampire

action-binding-generator/src/main/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/typing/TypingGeneration.kt

@@ -76,8 +76,13 @@ private fun EnumTyping.buildEnumCustomType(
     fieldName: String,
     className: String,
 ): TypeSpec {
-    val itemsNames = itemsNames ?: items.map { it.toPascalCase() }
-    val itemsNameMap = items.zip(itemsNames).toMap()
+    val sortedItems = items.sorted()
+    val itemsNames =
+        itemsNames ?: sortedItems
+            .map { it.toPascalCase() }
+            .groupBy { it }
+            .values
+            .flatMap { it.mapIndexed { index, name -> "$name${if (index > 0) "_${index + 1}" else ""}" } }
     val typeName = this.typeName?.toPascalCase() ?: fieldName.toPascalCase()
     val actionPackageName = coords.owner.toKotlinPackageName()
     val sealedClassName = this.getClassName(actionPackageName, className, fieldName)
@@ -92,11 +97,11 @@ private fun EnumTyping.buildEnumCustomType(
                 .build(),
         ).addProperty(PropertySpec.builder("stringValue", String::class).initializer("stringValue").build())
         .addTypes(
-            this.items.map {
+            sortedItems.mapIndexed { i, it ->
                 val itemName =
-                    itemsNameMap[it]?.let {
+                    itemsNames[i].let {
                         if (it == "Custom") "CustomEnum" else it
-                    } ?: error("FIXME: key=$it absent from $itemsNameMap")
+                    }
                 TypeSpec
                     .objectBuilder(itemName)
                     .superclass(sealedClassName)

action-binding-generator/src/test/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/bindingsfromunittests/ActionWithAllTypesOfInputs.kt

@@ -301,13 +301,17 @@ public data class ActionWithAllTypesOfInputs private constructor(
     public sealed class Bin(
         public val stringValue: String,
     ) {
-        public object Foo : ActionWithAllTypesOfInputs.Bin("foo")
+        public object Bam123 : ActionWithAllTypesOfInputs.Bin("bam-123")
 
-        public object BooBar : ActionWithAllTypesOfInputs.Bin("boo-bar")
+        public object Bam123_2 : ActionWithAllTypesOfInputs.Bin("bam/123")
+
+        public object Bam123_3 : ActionWithAllTypesOfInputs.Bin("bam:123")
 
         public object Baz123 : ActionWithAllTypesOfInputs.Bin("baz123")
 
-        public object Bam123 : ActionWithAllTypesOfInputs.Bin("bam:123")
+        public object BooBar : ActionWithAllTypesOfInputs.Bin("boo-bar")
+
+        public object Foo : ActionWithAllTypesOfInputs.Bin("foo")
 
         public class Custom(
             customStringValue: String,
@@ -341,10 +345,10 @@ public data class ActionWithAllTypesOfInputs private constructor(
     ) {
         public object One : ActionWithAllTypesOfInputs.MyEnum("one")
 
-        public object Two : ActionWithAllTypesOfInputs.MyEnum("two")
-
         public object Three : ActionWithAllTypesOfInputs.MyEnum("three")
 
+        public object Two : ActionWithAllTypesOfInputs.MyEnum("two")
+
         public class Custom(
             customStringValue: String,
         ) : ActionWithAllTypesOfInputs.MyEnum(customStringValue)

action-binding-generator/src/test/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/generation/GenerationTest.kt

@@ -96,7 +96,7 @@ class GenerationTest :
                 "bin-kin" to BooleanTyping,
                 "int-pint" to IntegerTyping,
                 "flo-pint" to FloatTyping,
-                "fin-bin" to EnumTyping("Bin", listOf("foo", "boo-bar", "baz123", "bam:123")),
+                "fin-bin" to EnumTyping("Bin", listOf("foo", "boo-bar", "baz123", "bam:123", "bam-123", "bam/123")),
                 "goo-zen" to IntegerWithSpecialValueTyping("Zen", mapOf("Special1" to 3, "Special2" to -1)),
                 "bah-enum" to EnumTyping(null, listOf("helloworld"), listOf("HelloWorld")),
                 "list-strings" to ListOfTypings(",", StringTyping),