restructure animation tests

Author: timhendriks93

test/animation/helper.h

@@ -0,0 +1,36 @@
+#include <Arduino.h>
+
+#define FPS 60
+#define FRAMES 5
+#define FRAME_MICROS 16667
+
+byte modeChangeCount = 0;
+
+struct positionLog {
+  int index;
+  int positions[20];
+};
+
+positionLog lastPositions[16];
+
+void setUpHelper(void) {
+  for (int id = 0; id < 16; id++) {
+    lastPositions[id].index = 0;
+
+    for (int i = 0; i < 20; i++) {
+      lastPositions[id].positions[i] = 0;
+    }
+  }
+
+  modeChangeCount = 0;
+}
+
+void onModeChange(byte prevMode, byte newMode) {
+  modeChangeCount++;
+}
+
+void move(byte servoID, int position) {
+  int index = lastPositions[servoID].index;
+  lastPositions[servoID].positions[index] = position;
+  lastPositions[servoID].index++;
+}

test/animation/test_live/test_live.cpp

@@ -1,38 +1,17 @@
 #include "../../SerialMock.h"
+#include "../helper.h"
 #include "BlenderServoAnimation.h"
 #include <unity.h>
 
 using namespace BlenderServoAnimation;
 
-#define FPS 60
-#define FRAMES 5
-
-struct positionLog {
-  int index;
-  int positions[20];
-};
-
-positionLog lastPositions[16];
-
 void setUp(void) {
-  for (int id = 0; id < 16; id++) {
-    lastPositions[id].index = 0;
-
-    for (int i = 0; i < 20; i++) {
-      lastPositions[id].positions[i] = 0;
-    }
-  }
-}
-
-void move(byte servoID, int position) {
-  int index = lastPositions[servoID].index;
-  lastPositions[servoID].positions[index] = position;
-  lastPositions[servoID].index++;
+  setUpHelper();
 }
 
 const int positions[5] PROGMEM = {350, 340, 330, 340, 330};
 
-void test_multiple_servos(void) {
+void test_live(void) {
   Animation animation;
   SerialMock mock;
   Servo servos[] = {
@@ -65,7 +44,7 @@ void test_multiple_servos(void) {
   TEST_ASSERT_EQUAL(355, lastPositions[1].positions[1]);
 }
 
-void test_skip(void) {
+void test_skip_incomplete_command(void) {
   Animation animation;
   SerialMock mock;
   Servo servo(0, move);
@@ -85,9 +64,57 @@ void test_skip(void) {
   TEST_ASSERT_EQUAL(360, lastPositions[0].positions[1]);
 }
 
+void test_call_twice(void) {
+  Serial_ mock;
+  Animation animation(FPS, FRAMES);
+  animation.onModeChange(onModeChange);
+
+  TEST_ASSERT_EQUAL(Animation::MODE_DEFAULT, animation.getMode());
+  animation.live(mock);
+  TEST_ASSERT_EQUAL(Animation::MODE_LIVE, animation.getMode());
+  animation.live(mock);
+  TEST_ASSERT_EQUAL(Animation::MODE_LIVE, animation.getMode());
+
+  TEST_ASSERT_EQUAL(1, modeChangeCount);
+}
+
+void test_prevented(void) {
+  Serial_ mock;
+  Animation animation(FPS, FRAMES);
+
+  animation.play(0);
+  TEST_ASSERT_EQUAL(Animation::MODE_PLAY, animation.getMode());
+  animation.live(mock);
+  TEST_ASSERT_EQUAL(Animation::MODE_PLAY, animation.getMode());
+  animation.pause();
+  TEST_ASSERT_EQUAL(Animation::MODE_PAUSE, animation.getMode());
+  animation.live(mock);
+  TEST_ASSERT_EQUAL(Animation::MODE_PAUSE, animation.getMode());
+  animation.loop(0);
+  TEST_ASSERT_EQUAL(Animation::MODE_LOOP, animation.getMode());
+  animation.live(mock);
+  TEST_ASSERT_EQUAL(Animation::MODE_LOOP, animation.getMode());
+  animation.stop();
+  TEST_ASSERT_EQUAL(Animation::MODE_STOP, animation.getMode());
+  animation.live(mock);
+  TEST_ASSERT_EQUAL(Animation::MODE_STOP, animation.getMode());
+}
+
+void test_allowed(void) {
+  Serial_ mock;
+  Animation animation(FPS, FRAMES);
+
+  TEST_ASSERT_EQUAL(Animation::MODE_DEFAULT, animation.getMode());
+  animation.live(mock);
+  TEST_ASSERT_EQUAL(Animation::MODE_LIVE, animation.getMode());
+}
+
 int main(int argc, char **argv) {
   UNITY_BEGIN();
-  RUN_TEST(test_multiple_servos);
-  RUN_TEST(test_skip);
+  RUN_TEST(test_live);
+  RUN_TEST(test_skip_incomplete_command);
+  RUN_TEST(test_call_twice);
+  RUN_TEST(test_prevented);
+  RUN_TEST(test_allowed);
   UNITY_END();
 }