Use timezone-aware datetime for dataset lifecycle ops

Co-authored-by: ponyisi <[email protected]>

Author: Copilot

servicex_app/servicex_app/resources/internal/dataset_lifecycle_ops.py

@@ -25,7 +25,7 @@
 # CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-from datetime import datetime, timedelta
+from datetime import datetime, timedelta, timezone
 
 from flask import request, current_app
 
@@ -39,7 +39,7 @@ def post(self):
         """
         Obsolete cached datasets older than N hours
         """
-        now = datetime.now()
+        now = datetime.now(timezone.utc)
         try:
             age = float(request.get_json().get("age", 24))
         except Exception:

servicex_app/servicex_app_test/resources/internal/test_dataset_lifecycle_ops.py

@@ -25,7 +25,7 @@
 # CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-from datetime import datetime
+from datetime import datetime, timezone
 from unittest.mock import patch
 
 from pytest import fixture
@@ -43,8 +43,8 @@ def fake_dataset_list(self):
         ) as dsfunc:
             dsfunc.return_value = [
                 Dataset(
-                    last_used=datetime(2022, 1, 1),
-                    last_updated=datetime(2022, 1, 1),
+                    last_used=datetime(2022, 1, 1, tzinfo=timezone.utc),
+                    last_updated=datetime(2022, 1, 1, tzinfo=timezone.utc),
                     id=1,
                     name="not-orphaned",
                     events=100,
@@ -54,8 +54,8 @@ def fake_dataset_list(self):
                     did_finder="rucio",
                 ),
                 Dataset(
-                    last_used=datetime.now(),
-                    last_updated=datetime.now(),
+                    last_used=datetime.now(timezone.utc),
+                    last_updated=datetime.now(timezone.utc),
                     id=2,
                     name="orphaned",
                     events=100,