[sk4d] Fix assertion on SkParagraphBuilder::Build()

viniciusfbb · viniciusfbb · commit ff318ce6fbce · 2025-03-14T18:29:18.000-03:00
diff --git a/sk4d/modules/skparagraph/src/sk4d_paragraphbuilder.cpp b/sk4d/modules/skparagraph/src/sk4d_paragraphbuilder.cpp
@@ -26,7 +26,7 @@ sk_paragraph_t* sk4d_paragraphbuilder_build(sk_paragraphbuilder_t* self) {
 sk_paragraphbuilder_t* sk4d_paragraphbuilder_create(const sk_paragraphstyle_t* paragraph_style) {
     auto fontCollection = sk_make_sp<skia::textlayout::FontCollection>();
     fontCollection->setDefaultFontManager(Sk4DComp::FontMgrRefDefault());
-    return ToParagraphBuilder(skia::textlayout::ParagraphBuilder::make(AsParagraphStyle(*paragraph_style), fontCollection).release());
+    return ToParagraphBuilder(skia::textlayout::ParagraphBuilder::make(AsParagraphStyle(*paragraph_style), fontCollection, Sk4DComp::UnicodeMake()).release());
 
 }
 
@@ -35,7 +35,7 @@ sk_paragraphbuilder_t* sk4d_paragraphbuilder_create2(const sk_paragraphstyle_t*
     if (enable_font_fallback)
         fontCollection->setDefaultFontManager(Sk4DComp::FontMgrRefDefault());
     fontCollection->setAssetFontManager(sk_ref_sp(AsFontMgr(font_provider)));
-    return ToParagraphBuilder(skia::textlayout::ParagraphBuilder::make(AsParagraphStyle(*paragraph_style), fontCollection).release());
+    return ToParagraphBuilder(skia::textlayout::ParagraphBuilder::make(AsParagraphStyle(*paragraph_style), fontCollection, Sk4DComp::UnicodeMake()).release());
 }
 
 void sk4d_paragraphbuilder_destroy(sk_paragraphbuilder_t* self) {

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ sk_paragraph_t* sk4d_paragraphbuilder_build(sk_paragraphbuilder_t* self) {`
`26`	`26`	`sk_paragraphbuilder_t* sk4d_paragraphbuilder_create(const sk_paragraphstyle_t* paragraph_style) {`
`27`	`27`	`auto fontCollection = sk_make_sp<skia::textlayout::FontCollection>();`
`28`	`28`	`fontCollection->setDefaultFontManager(Sk4DComp::FontMgrRefDefault());`
`29`		`- return ToParagraphBuilder(skia::textlayout::ParagraphBuilder::make(AsParagraphStyle(*paragraph_style), fontCollection).release());`
	`29`	`+ return ToParagraphBuilder(skia::textlayout::ParagraphBuilder::make(AsParagraphStyle(*paragraph_style), fontCollection, Sk4DComp::UnicodeMake()).release());`
`30`	`30`
`31`	`31`	`}`
`32`	`32`
`@@ -35,7 +35,7 @@ sk_paragraphbuilder_t* sk4d_paragraphbuilder_create2(const sk_paragraphstyle_t*`
`35`	`35`	`if (enable_font_fallback)`
`36`	`36`	`fontCollection->setDefaultFontManager(Sk4DComp::FontMgrRefDefault());`
`37`	`37`	`fontCollection->setAssetFontManager(sk_ref_sp(AsFontMgr(font_provider)));`
`38`		`- return ToParagraphBuilder(skia::textlayout::ParagraphBuilder::make(AsParagraphStyle(*paragraph_style), fontCollection).release());`
	`38`	`+ return ToParagraphBuilder(skia::textlayout::ParagraphBuilder::make(AsParagraphStyle(*paragraph_style), fontCollection, Sk4DComp::UnicodeMake()).release());`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`void sk4d_paragraphbuilder_destroy(sk_paragraphbuilder_t* self) {`