[WIP] #17 Migrate from paperclip to active storage (#137)

* install active storage and migrate

* temp fix user update

Some methods for params were commented out for an unknown reason. This
add's them back and the update method works properly.

* add feature flag for active_storage

setup initial change for user avatar

* ignore local active storage attachments

fix var

* add feature flag to workshop attachments

* add feature flag to all models using paperclip

* check if avatar is attached

* add active storage validations gem

* add attachment validations

* add feature flag to test config

* fix jpeg content type

* add check for attached avatar

* update tests

* add validation gem to test group

revert

* fix merge

* add validation tests

* move spec

* fix rails 8.1 upgrade issues with enums

* revert

* clean up

clean up

* ignore local storage

* update schema

* clean up

* update set_has_attachment

* Remove duplicate gem

* Remove active storage conditionals

* Remove more active_storage env var conditionals

* Remove merge conflict text

* Remove 'image/jpg' type bc it's invalid

* Make migration reversible

* WIP: testing image usage

* Update tests to activestorage (and always show image in navbar)

---------

Co-authored-by: maebeale <[email protected]>

Author: jmilljr24

.gitignore

@@ -48,3 +48,5 @@ node_modules
 *.local
 
 .vite
+# Ignore local Active Storage
+storage

Gemfile

@@ -46,6 +46,8 @@ gem "country_select"
 gem "turbo-rails", "~> 2.0"
 gem "stimulus-rails", "~> 1.3"
 
+gem "active_storage_validations", "~> 3.0"
+
 group :development, :test do
   gem "better_errors"
   gem "brakeman", require: false

Gemfile.lock

@@ -47,6 +47,12 @@ GEM
       erubi (~> 1.11)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
+    active_storage_validations (3.0.2)
+      activejob (>= 6.1.4)
+      activemodel (>= 6.1.4)
+      activestorage (>= 6.1.4)
+      activesupport (>= 6.1.4)
+      marcel (>= 1.0.3)
     activejob (8.1.0.beta1)
       activesupport (= 8.1.0.beta1)
       globalid (>= 0.3.6)
@@ -446,6 +452,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  active_storage_validations (~> 3.0)
   apipie-rails (~> 1.5.0)
   aws-sdk-s3
   bcrypt (= 3.1.16)

app/decorators/workshop_decorator.rb

@@ -148,18 +148,17 @@ def main_image
   end
 
   def thumbnail_image
-    if legacy && !thumbnail.exists?
-      main_image
-    else
+    # TODO Figure out if we need main_image
+    if thumbnail.attached?
       thumbnail
     end
   end
 
   def header_image
-    if !header.exists?
-      thumbnail_image
-    else
+    if header.attached?
       header
+    elsif thumbnail.attached?
+      thumbnail
     end
   end
 

app/models/attachment.rb

@@ -1,10 +1,11 @@
 class Attachment < ApplicationRecord
   belongs_to :owner, polymorphic: true
 
-  has_attached_file :file
-  validates_attachment :file, content_type: { content_type: %w(application/pdf application/msword image/gif image/jpg image/jpeg image/png) }
+  ACCEPTED_CONTENT_TYPES = %w[application/pdf application/msword image/gif image/jpeg image/png].freeze
+  has_one_attached :file
+  validates :file, content_type: ACCEPTED_CONTENT_TYPES
 
   def name
-    'Pdf Attachment'
+    "Pdf Attachment"
   end
 end

app/models/ckeditor/attachment_file.rb

@@ -1,11 +1,6 @@
 class Ckeditor::AttachmentFile < ApplicationRecord # Ckeditor::Asset
-  # has_attached_file :data,
-  #                   :url => "/ckeditor_assets/attachments/:id/:filename",
-  #                   :path => "/ckeditor_assets/attachments/:id/:filename"
-  #
-  # validates_attachment_presence :data
-  # validates_attachment_size :data, :less_than => 100.megabytes
-  # do_not_validate_attachment_file_type :data
+  has_one_attached :data
+  validates :data, size: {less_than: 100.megabytes}, attached: true
 
   def url_thumb
     @url_thumb ||= nil # Ckeditor::Utils.filethumb(filename)

app/models/ckeditor/picture.rb

@@ -1,12 +1,7 @@
 class Ckeditor::Picture < ApplicationRecord # Ckeditor::Asset
-  # has_attached_file :data,
-  #                   :url  => "/ckeditor_assets/pictures/:id/:style_:basename.:extension",
-  #                   :path => "/ckeditor_assets/pictures/:id/:style_:basename.:extension",
-  #                   :styles => { :content => '800>', :thumb => '118x100#' }
-  #
-  # validates_attachment_presence :data
-  # validates_attachment_size :data, :less_than => 2.megabytes
-  # validates_attachment_content_type :data, :content_type => /\Aimage/
+  ACCEPTED_CONTENT_TYPES = ["image/jpeg", "image/png"].freeze
+  has_one_attached :data
+  validates :data, size: {less_than: 2.megabytes}, content_type: ACCEPTED_CONTENT_TYPES, attached: true
 
   def url_content
     url(:content)
@@ -20,6 +15,5 @@ def url(param)
     else
       actual_url.gsub("/original", "/thumb")
     end
-
   end
 end

app/models/image.rb

@@ -2,11 +2,7 @@ class Image < ApplicationRecord
   belongs_to :owner, polymorphic: true
   belongs_to :report, optional: true
 
-  has_attached_file :file,
-                    styles: { medium: '300x300>', thumb: '100x100>' },
-                    default_url:
-                      ActionController::Base.helpers.asset_path(
-                        'workshop_default.png'
-                      )
-  validates_attachment :file, content_type: { content_type:  ["image/jpg", "image/jpeg", "image/png", "image/gif"] }
+  ACCEPTED_CONTENT_TYPES = ["image/jpeg", "image/png", "image/gif"].freeze
+  has_one_attached :file
+  validates :file, content_type: ACCEPTED_CONTENT_TYPES
 end

app/models/media_file.rb

@@ -3,13 +3,11 @@ class MediaFile < ApplicationRecord
   belongs_to :workshop, optional: true
   belongs_to :workshop_log, optional: true
 
-  has_attached_file :file
-
-  FORM_FILE_CONTENT_TYPES = ["image/jpeg", "image/jpg", "image/png",
-                             "application/pdf", "application/msword",
-                             "application/vnd.openxmlformats-officedocument.wordprocessingml.document",
-                             "application/vnd.ms-excel",
-                             "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet"]
-
-   validates_attachment :file, content_type: { content_type:  FORM_FILE_CONTENT_TYPES }
+  FORM_FILE_CONTENT_TYPES = ["image/jpeg", "image/png",
+    "application/pdf", "application/msword",
+    "application/vnd.openxmlformats-officedocument.wordprocessingml.document",
+    "application/vnd.ms-excel",
+    "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet"]
+  has_one_attached :file
+  validates :file, content_type: FORM_FILE_CONTENT_TYPES
 end

app/models/project_user.rb

@@ -3,7 +3,7 @@ class ProjectUser < ApplicationRecord
   belongs_to :project
   belongs_to :user
 
-  scope :liaisons, -> { where(position: 1) }
+  scope :liaisons, -> { where(position: "liaison") }
   # Validations
   validates_presence_of :project_id