Prune code supporting Rails < 7.2

Author: JonRowe

Gemfile-rails-dependencies

@@ -36,11 +36,8 @@ when nil, false, ""
   if RUBY_VERSION.to_f > 3.1
     gem "rails", "~> 8.0.0"
     gem 'sqlite3', '~> 2.0', platforms: [:ruby]
-  elsif RUBY_VERSION.to_f > 3.0
-    gem "rails", "~> 7.2.0"
-    gem 'sqlite3', '~> 1.7', platforms: [:ruby]
   else
-    gem "rails", "~> 7.1.0"
+    gem "rails", "~> 7.2.0"
     gem 'sqlite3', '~> 1.7', platforms: [:ruby]
   end
 
@@ -49,17 +46,9 @@ when nil, false, ""
 else
   version_number = version.split(' ').last
 
-  gem 'concurrent-ruby', '1.3.4' if version_number < '7.1'
-
   gem "rails", version
   gem 'activerecord-jdbcsqlite3-adapter', platforms: [:jruby]
 
-  # This version number reflects our build version not our actual version,
-  # this will be fixed in 7.1.4 and should be removed then.
-  if version_number == '7.1.0'
-    gem 'selenium-webdriver', '< 4.20.0', require: false
-  else
-    gem 'selenium-webdriver', require: false
-  end
+  gem 'selenium-webdriver', require: false
   add_sqlite3_gem_dependency(version_number)
 end

example_app_generator/generate_app.rb

@@ -11,7 +11,6 @@
   'ci_retry_bundle_install.sh'
 )
 function_script_file = File.join(rspec_rails_repo_path, 'script/functions.sh')
-capybara_backport_path = File.join(rspec_rails_repo_path, 'example_app_generator/spec/support/capybara.rb')
 
 in_root do
   prepend_to_file "Rakefile", "require 'active_support/all'"
@@ -29,10 +28,8 @@
 
   gsub_file "Gemfile", /.*rails-controller-testing.*/, "gem 'rails-controller-testing', git: 'https://github.com/rails/rails-controller-testing'"
 
-  # sqlite3 is an optional, unspecified, dependency of which Rails 6.0 only supports `~> 1.4`, Ruby 2.7 only supports < 1.7 and Rails 8.0 only supports `~> 2.0`
-  if RUBY_VERSION.to_f < 3
-    gsub_file "Gemfile", /.*gem..sqlite3.*/, "gem 'sqlite3', '~> 1.4', '< 1.7'"
-  elsif Rails::VERSION::STRING > '8'
+  # sqlite3 is an optional, unspecified, dependency of which Rails 8.0 only supports `~> 2.0`
+  if Rails::VERSION::STRING > '8'
     gsub_file "Gemfile", /.*gem..sqlite3.*/, "gem 'sqlite3', '~> 2.0'"
   else
     gsub_file "Gemfile", /.*gem..sqlite3.*/, "gem 'sqlite3', '~> 1.7'"
@@ -66,13 +63,4 @@
             'REPLACE_BUNDLE_PATH',
             bundle_install_path
   chmod 'ci_retry_bundle_install.sh', 0755
-
-  copy_file capybara_backport_path, 'spec/support/capybara.rb'
-
-  if Rails::VERSION::STRING < '7.2'
-    create_file 'app/assets/config/manifest.js' do
-      "//= link application.css"
-    end
-    create_file 'app/assets/stylesheets/application.css'
-  end
 end

example_app_generator/spec/support/capybara.rb

@@ -43,17 +43,11 @@ require_file_stub 'config/environment' do
         # Don't care if the mailer can't send.
         config.action_mailer.raise_delivery_errors = false unless ENV['NO_ACTION_MAILER']
         if ENV['CUSTOM_PREVIEW_PATH']
-          if Rails::VERSION::STRING.to_f >= 7.1
-            config.action_mailer.preview_paths = [ENV['CUSTOM_PREVIEW_PATH']]
-          else
-            config.action_mailer.preview_path = ENV['CUSTOM_PREVIEW_PATH']
-          end
+          config.action_mailer.preview_paths = [ENV['CUSTOM_PREVIEW_PATH']]
         end
         if ENV['SHOW_PREVIEWS']
           config.action_mailer.show_previews = (ENV['SHOW_PREVIEWS'] == 'true')
         end
-
-        config.active_record.legacy_connection_handling = false if Rails::VERSION::STRING.start_with?('7.0')
       end
     end
 
@@ -68,11 +62,7 @@ exit(0) if ENV['NO_ACTION_MAILER']
 if ENV['DEFAULT_URL']
   puts ActionMailer::Base.default_url_options[:host]
 elsif defined?(::ActionMailer::Preview)
-  if Rails::VERSION::STRING.to_f >= 7.1
-    puts Rails.application.config.action_mailer.preview_paths
-  else
-    puts Rails.application.config.action_mailer.preview_path
-  end
+  puts Rails.application.config.action_mailer.preview_paths
 end
 
 # This will force the loading of ActionMailer settings to ensure we do not

example_app_generator/spec/support/default_preview_path

@@ -40,26 +40,17 @@ def capture_exec(*ops)
     CaptureExec.new(out, $?.exitstatus)
   end
 
-  if Rails::VERSION::STRING.to_f >= 7.1
-    let(:expected_custom_path) { "/custom/path\n#{::Rails.root}/test/mailers/previews" }
-    let(:expected_rspec_path) { "#{::Rails.root}/spec/mailers/previews\n#{::Rails.root}/test/mailers/previews" }
-
-    def have_no_preview(opts = {})
-      expected_io =
-        if opts[:actually_blank]
-          be_blank
-        else
-          "#{::Rails.root}/test/mailers/previews"
-        end
-      have_attributes(io: expected_io, exit_status: 0)
-    end
-  else
-    let(:expected_custom_path) { '/custom/path' }
-    let(:expected_rspec_path) { "#{::Rails.root}/spec/mailers/previews" }
-
-    def have_no_preview(_opts = {})
-      have_attributes(io: be_blank, exit_status: 0)
-    end
+  let(:expected_custom_path) { "/custom/path\n#{::Rails.root}/test/mailers/previews" }
+  let(:expected_rspec_path) { "#{::Rails.root}/spec/mailers/previews\n#{::Rails.root}/test/mailers/previews" }
+
+  def have_no_preview(opts = {})
+    expected_io =
+      if opts[:actually_blank]
+        be_blank
+      else
+        "#{::Rails.root}/test/mailers/previews"
+      end
+    have_attributes(io: expected_io, exit_status: 0)
   end
 
   let(:exec_script) {

example_app_generator/spec/verify_mailer_preview_path_spec.rb

@@ -59,7 +59,7 @@ def with_unbundled_env
   # We want fresh `example_app` project with empty `spec` dir except helpers.
   # FileUtils.cp_r on Ruby 1.9.2 doesn't preserve permissions.
   system('cp', '-r', example_app_dir, aruba_dir)
-  helpers = %w[spec/spec_helper.rb spec/rails_helper.rb spec/support/capybara.rb]
+  helpers = %w[spec/spec_helper.rb spec/rails_helper.rb]
   directories = []
 
   Dir["#{aruba_dir}/spec/**/*"].each do |path|

features/support/env.rb

@@ -41,13 +41,9 @@
 RSpec.configure do |config|
 <% if RSpec::Rails::FeatureCheck.has_active_record? -%>
   # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
-<% if ::Rails::VERSION::STRING < "7.1.0" -%>
-  config.fixture_path = Rails.root.join('spec/fixtures')
-<% else -%>
   config.fixture_paths = [
     Rails.root.join('spec/fixtures')
   ]
-<% end -%>
 
   # If you're not using ActiveRecord, or you'd prefer not to run each of your
   # examples within a transaction, remove the following line or assign false
@@ -65,7 +61,9 @@
   # note if you'd prefer not to run each example within a transaction, you
   # should set use_transactional_fixtures to false.
   #
-  # config.fixture_path = Rails.root.join('spec/fixtures')
+  # config.fixture_paths = [
+  #   Rails.root.join('spec/fixtures')
+  # ]
   # config.use_transactional_fixtures = true
 
 <% end -%>
@@ -77,7 +75,7 @@
   #     end
   #
   # The different available types are documented in the features, such as in
-  # https://rspec.info/features/7-1/rspec-rails
+  # https://rspec.info/features/8-0/rspec-rails
   #
   # You can also this infer these behaviours automatically by location, e.g.
   # /spec/models would pull in the same behaviour as `type: :model` but this

lib/generators/rspec/install/templates/spec/rails_helper.rb

@@ -64,18 +64,10 @@ def config_preview_path?(options)
         end
       end
 
-      if ::Rails::VERSION::STRING >= "7.1.0"
-        def config_default_preview_path(options)
-          return unless options.preview_paths.empty?
+      def config_default_preview_path(options)
+        return unless options.preview_paths.empty?
 
-          options.preview_paths << "#{::Rails.root}/spec/mailers/previews"
-        end
-      else
-        def config_default_preview_path(options)
-          return unless options.preview_path.blank?
-
-          options.preview_path = "#{::Rails.root}/spec/mailers/previews"
-        end
+        options.preview_paths << "#{::Rails.root}/spec/mailers/previews"
       end
 
       def supports_action_mailer_previews?(config)

lib/rspec-rails.rb

@@ -1,4 +1,3 @@
-# rubocop: disable Metrics/ModuleLength
 module RSpec
   module Rails
     # Fake class to document RSpec Rails configuration options. In practice,
@@ -57,7 +56,7 @@ def self.add_test_type_configurations(config)
     end
 
     # @private
-    def self.initialize_configuration(config) # rubocop:disable Metrics/MethodLength,Metrics/CyclomaticComplexity,Metrics/AbcSize,Metrics/PerceivedComplexity
+    def self.initialize_configuration(config) # rubocop:disable Metrics/MethodLength
       config.backtrace_exclusion_patterns << /vendor\//
       config.backtrace_exclusion_patterns << %r{lib/rspec/rails}
 
@@ -69,12 +68,7 @@ def self.initialize_configuration(config) # rubocop:disable Metrics/MethodLength
       config.add_setting :use_transactional_fixtures, alias_with: :use_transactional_examples
       config.add_setting :use_instantiated_fixtures
       config.add_setting :global_fixtures
-
-      if ::Rails::VERSION::STRING < "7.1.0"
-        config.add_setting :fixture_path
-      else
-        config.add_setting :fixture_paths
-      end
+      config.add_setting :fixture_paths
 
       config.include RSpec::Rails::FixtureSupport, :use_fixtures
 
@@ -90,7 +84,7 @@ def self.initialize_configuration(config) # rubocop:disable Metrics/MethodLength
       config.add_setting :file_fixture_path, default: 'spec/fixtures/files'
       config.include RSpec::Rails::FileFixtureSupport
 
-      # Add support for fixture_path on fixture_file_upload
+      # Add support for fixture_paths on fixture_file_upload
       config.include RSpec::Rails::FixtureFileUploadSupport
 
       # This allows us to expose `render_views` as a config option even though it
@@ -114,40 +108,6 @@ def render_views?
           rendering_views?
         end
 
-        undef :rendering_views? if respond_to?(:rendering_views?)
-        def rendering_views?
-          !!rendering_views
-        end
-
-        # Define boolean predicates rather than relying on rspec-core due
-        # to the bug fix in rspec/rspec-core#2736, note some of these
-        # predicates are a bit nonsensical, but they exist for backwards
-        # compatibility, we can tidy these up in `rspec-rails` 5.
-        undef :fixture_path? if respond_to?(:fixture_path?)
-        def fixture_path?
-          !!fixture_path
-        end
-
-        undef :global_fixtures? if respond_to?(:global_fixtures?)
-        def global_fixtures?
-          !!global_fixtures
-        end
-
-        undef :infer_base_class_for_anonymous_controllers? if respond_to?(:infer_base_class_for_anonymous_controllers?)
-        def infer_base_class_for_anonymous_controllers?
-          !!infer_base_class_for_anonymous_controllers
-        end
-
-        undef :use_instantiated_fixtures? if respond_to?(:use_instantiated_fixtures?)
-        def use_instantiated_fixtures?
-          !!use_instantiated_fixtures
-        end
-
-        undef :use_transactional_fixtures? if respond_to?(:use_transactional_fixtures?)
-        def use_transactional_fixtures?
-          !!use_transactional_fixtures
-        end
-
         def infer_spec_type_from_file_location!
           DIRECTORY_MAPPINGS.each do |type, dir_parts|
             escaped_path = Regexp.compile(dir_parts.join('[\\\/]') + '[\\\/]')
@@ -163,29 +123,6 @@ def filter_rails_from_backtrace!
           filter_gems_from_backtrace "activemodel", "activerecord",
                                      "activesupport", "activejob"
         end
-
-        # @deprecated TestFixtures#fixture_path is deprecated and will be removed in Rails 7.2
-        if ::Rails::VERSION::STRING >= "7.1.0"
-          def fixture_path
-            RSpec.deprecate(
-              "config.fixture_path",
-              replacement: "config.fixture_paths",
-              message: "Rails 7.1 has deprecated the singular fixture_path in favour of an array." \
-              "You should migrate to plural:"
-            )
-            fixture_paths&.first
-          end
-
-          def fixture_path=(path)
-            RSpec.deprecate(
-              "config.fixture_path = #{path.inspect}",
-              replacement: "config.fixture_paths = [#{path.inspect}]",
-              message: "Rails 7.1 has deprecated the singular fixture_path in favour of an array." \
-              "You should migrate to plural:"
-            )
-            self.fixture_paths = Array(path)
-          end
-        end
       end
 
       add_test_type_configurations(config)
@@ -219,4 +156,3 @@ def fixture_path=(path)
     initialize_configuration RSpec.configuration
   end
 end
-# rubocop: enable Metrics/ModuleLength