Tidy up rack status in spec

Author: JonRowe

spec/generators/rspec/scaffold/scaffold_generator_spec.rb

@@ -7,6 +7,12 @@
   include RSpec::Support::InSubProcess
   setup_default_destination
 
+  if Rack::RELEASE < "3.1.0"
+    let(:unprocessable_status) { ":unprocessable_entity" }
+  else
+    let(:unprocessable_status) { ":unprocessable_content" }
+  end
+
   describe 'standard request specs' do
     subject(:filename) { file('spec/requests/posts_spec.rb') }
 
@@ -33,15 +39,7 @@
             .and(contain(/renders a response with 422 status \(i.e. to display the 'edit' template\)/))
         )
 
-        expect(
-          filename
-        ).to(
-          if Gem::Version.new(Rack::RELEASE) < Gem::Version.new("3.1")
-            contain(/expect\(response\).to have_http_status\(:unprocessable_entity\)/)
-          else
-            contain(/expect\(response\).to have_http_status\(:unprocessable_content\)/)
-          end
-        )
+        expect(filename).to contain(/expect\(response\).to have_http_status\(#{unprocessable_status}\)/)
       end
     end
 
@@ -109,16 +107,7 @@
         expect(filename).to contain(/renders a response with 422 status \(i.e. to display the 'new' template\)/)
                               .and(contain(/renders a response with 422 status \(i.e. to display the 'edit' template\)/))
 
-        expect(
-          filename
-        ).to(
-          if Gem::Version.new(Rack::RELEASE) < Gem::Version.new("3.1")
-            contain(/expect\(response\).to have_http_status\(:unprocessable_entity\)/)
-          else
-            contain(/expect\(response\).to have_http_status\(:unprocessable_content\)/)
-          end
-        )
-
+        expect(filename).to contain(/expect\(response\).to have_http_status\(#{unprocessable_status}\)/)
         expect(filename).not_to contain(/"renders a JSON response with the new \w+"/)
         expect(filename).not_to contain(/"renders a JSON response with errors for the new \w+"/)
         expect(filename).not_to contain(/"renders a JSON response with the \w+"/)