[wip] Ruby 2.4.0 support (#1765)

* run ruby 2.4.0 builds

* fix build on 2.4.0 by insisting on uptodate json

* supress rubocop on 2.4.0

* Change active job spec to use literals thus avoiding Ruby 2.4.0 warning

* disable 2.4.0 builds on unsupported Rubies

* temporarily suppress builds that rails will eventually support

Author: JonRowe

.travis.yml

@@ -33,6 +33,7 @@ script: "script/run_build 2>&1"
 
 rvm:
   - 1.8.7
+  - 2.4.0
   - 2.3.1
   - 2.2
   - 2.1
@@ -63,6 +64,10 @@ matrix:
       env: RAILS_VERSION=master
     - rvm: 2.3.1
       env: RAILS_VERSION=5-0-stable
+    - rvm: 2.4.0
+      env: RAILS_VERSION=master
+    - rvm: 2.4.0
+      env: RAILS_VERSION=5-0-stable
   exclude:
     # 3.0.x is not supported on MRI 2.0+
     - rvm: 2.0.0
@@ -73,6 +78,8 @@ matrix:
       env: RAILS_VERSION='~> 3.0.20'
     - rvm: 2.3.1
       env: RAILS_VERSION='~> 3.0.20'
+    - rvm: 2.4.0
+      env: RAILS_VERSION='~> 3.0.20'
     # 4.x is not supported on MRI ruby-1.8.7 or 1.9.2
     - rvm: 1.8.7
       env: RAILS_VERSION='~> 4.0.4'
@@ -103,11 +110,32 @@ matrix:
       env: RAILS_VERSION='~> 3.1.12'
     - rvm: 2.3.1
       env: RAILS_VERSION='~> 3.1.12'
+    # MRI 2.4+ is not supported on a few versions
+    - rvm: 2.4.0
+      env: RAILS_VERSION='~> 4.1.0'
+    - rvm: 2.4.0
+      env: RAILS_VERSION=4-1-stable
+    - rvm: 2.4.0
+      env: RAILS_VERSION='~> 4.0.4'
+    - rvm: 2.4.0
+      env: RAILS_VERSION=4-0-stable
+    - rvm: 2.4.0
+      env: RAILS_VERSION='~> 3.2.17'
+    - rvm: 2.4.0
+      env: RAILS_VERSION=3-2-stable
+    - rvm: 2.4.0
+      env: RAILS_VERSION='~> 3.1.12'
   allow_failures:
     - rvm: 2.2.2
       env: RAILS_VERSION=master
     - rvm: 2.3.1
       env: RAILS_VERSION=master
+    - rvm: 2.4.0
+      env: RAILS_VERSION=master
+    - rvm: 2.4.0
+      env: RAILS_VERSION='~> 4.2.0'
+    - rvm: 2.4.0
+      env: RAILS_VERSION=4-2-stable
   fast_finish: true
 
 branches:

Gemfile

@@ -20,6 +20,10 @@ end
 
 gem 'sqlite3', '~> 1.3.6'
 
+if RUBY_VERSION >= '2.4.0'
+  gem 'json', '>= 2.0.2'
+end
+
 if RUBY_VERSION >= '1.9.3'
   gem 'rake', '>= 10.0.0'
 else
@@ -53,7 +57,10 @@ if RUBY_VERSION <= '1.8.7'
   gem 'rubyzip', '< 1.0'
 end
 
-gem 'rubocop', "~> 0.23.0", :platform => [:ruby_19, :ruby_20, :ruby_21]
+unless RUBY_VERSION >= '2.4.0'
+  # our current rubocop version doesnt support the json version
+  gem 'rubocop', "~> 0.23.0", :platform => [:ruby_19, :ruby_20, :ruby_21]
+end
 
 custom_gemfile = File.expand_path("../Gemfile-custom", __FILE__)
 eval_gemfile custom_gemfile if File.exist?(custom_gemfile)

spec/rspec/rails/matchers/active_job_spec.rb

@@ -212,7 +212,7 @@ def perform; end
     it "passes with provided argument matchers" do
       expect {
         hello_job.perform_later(42, "David")
-      }.to have_enqueued_job.with(instance_of(Fixnum), instance_of(String))
+      }.to have_enqueued_job.with(42, "David")
     end
 
     it "generates failure message with all provided options" do