Merge pull request #2217 from koic/always_use_openssl_constants_for_digest_operations

Always use OpenSSL constants for Digest operations

Author: yahonda

lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "digest/sha1"
+require "openssl"
 
 module ActiveRecord
   module ConnectionAdapters
@@ -353,7 +353,7 @@ def index_name(table_name, options) # :nodoc:
           end
           # generate unique name using hash function
           if shortened_name.length > identifier_max_length
-            shortened_name = "i" + Digest::SHA1.hexdigest(default_name)[0, identifier_max_length - 1]
+            shortened_name = "i" + OpenSSL::Digest::SHA1.hexdigest(default_name)[0, identifier_max_length - 1]
           end
           @logger.warn "#{adapter_name} shortened default index name #{default_name} to #{shortened_name}" if @logger
           shortened_name

spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb

@@ -333,7 +333,7 @@ class ::TestEmployee < ActiveRecord::Base; end
           ("index_test_employees_on_first_name_and_middle_name_and_last_name"))
       else
         expect(@conn.index_name("test_employees", column: ["first_name", "middle_name", "last_name"])).to eq(
-          "i" + Digest::SHA1.hexdigest("index_test_employees_on_first_name_and_middle_name_and_last_name")[0, 29]
+          "i" + OpenSSL::Digest::SHA1.hexdigest("index_test_employees_on_first_name_and_middle_name_and_last_name")[0, 29]
         )
       end
     end
@@ -455,7 +455,7 @@ class ::TestComment < ActiveRecord::Base
     end
 
     it "should add foreign key" do
-      fk_name = "fk_rails_#{Digest::SHA256.hexdigest("test_comments_test_post_id_fk").first(10)}"
+      fk_name = "fk_rails_#{OpenSSL::Digest::SHA256.hexdigest("test_comments_test_post_id_fk").first(10)}"
 
       schema_define do
         add_foreign_key :test_comments, :test_posts
@@ -475,7 +475,7 @@ class ::TestComment < ActiveRecord::Base
     end
 
     it "should add foreign key with column" do
-      fk_name = "fk_rails_#{Digest::SHA256.hexdigest("test_comments_post_id_fk").first(10)}"
+      fk_name = "fk_rails_#{OpenSSL::Digest::SHA256.hexdigest("test_comments_post_id_fk").first(10)}"
 
       schema_define do
         add_foreign_key :test_comments, :test_posts, column: "post_id"