Skip to content

Commit d0411a5

Browse files
committed
[fbgemm_gpu] Fix test reliability with table order
- Fix test reliability with table order
1 parent 9df97a7 commit d0411a5

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1560,7 +1560,7 @@ def get_table_name_for_logging(table_names: Optional[list[str]]) -> str:
15601560
return "<Unknown>"
15611561
# Do this because sometimes multiple shards of the same table could appear
15621562
# in one TBE.
1563-
table_name_set = set(table_names)
1563+
table_name_set = sorted(list(set(table_names)))
15641564
if len(table_name_set) == 1:
15651565
return next(iter(table_name_set))
15661566
return f"<{len(table_name_set)} tables>: {table_name_set}"

fbgemm_gpu/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ def main(argv: list[str]) -> None:
655655
]
656656
+ [
657657
f"Programming Language :: Python :: {x}"
658-
for x in ["3", "3.9", "3.10", "3.11", "3.12", "3.13"]
658+
for x in ["3", "3.10", "3.11", "3.12", "3.13"]
659659
],
660660
)
661661

fbgemm_gpu/test/tbe/utils/split_embeddings_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -178,17 +178,17 @@ def test_get_table_name_for_logging(self) -> None:
178178
SplitTableBatchedEmbeddingBagsCodegen.get_table_name_for_logging(
179179
["t1", "t2"]
180180
),
181-
"<2 tables>: {'t1', 't2'}",
181+
"<2 tables>: ['t1', 't2']",
182182
)
183183
self.assertEqual(
184184
SplitTableBatchedEmbeddingBagsCodegen.get_table_name_for_logging(
185185
["t1", "t2", "t1"]
186186
),
187-
"<2 tables>: {'t1', 't2'}",
187+
"<2 tables>: ['t1', 't2']",
188188
)
189189
self.assertEqual(
190190
SplitTableBatchedEmbeddingBagsCodegen.get_table_name_for_logging([]),
191-
"<0 tables>: set()",
191+
"<0 tables>: []",
192192
)
193193

194194
@unittest.skipIf(*gpu_unavailable)

0 commit comments

Comments
 (0)