Skip to content

Commit 17a7653

Browse files
q10meta-codesync[bot]
authored andcommitted
Fix test reliability with table order (#5087)
Summary: X-link: https://github.com/facebookresearch/FBGEMM/pull/2097 - Fix test reliability with table order Pull Request resolved: #5087 Reviewed By: spcyppt Differential Revision: D86242426 Pulled By: q10 fbshipit-source-id: 4ec307ff8fd9151bddb6bf7354bfe06f67a1fa0b
1 parent 8c83b41 commit 17a7653

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

.github/workflows/_fbgemm_gpu_cuda_test.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,9 @@ jobs:
132132
# clang-16: error: unknown argument: '-fno-tree-loop-vectorize'
133133
run: . $PRELUDE; install_cxx_compiler $BUILD_ENV gcc
134134

135+
- name: Install Build Tools
136+
run: . $PRELUDE; install_build_tools $BUILD_ENV
137+
135138
- name: Install CUDA
136139
run: . $PRELUDE; install_cuda $BUILD_ENV ${{ matrix.cuda-version }}
137140

fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1560,7 +1560,7 @@ def get_table_name_for_logging(table_names: Optional[list[str]]) -> str:
15601560
return "<Unknown>"
15611561
# Do this because sometimes multiple shards of the same table could appear
15621562
# in one TBE.
1563-
table_name_set = set(table_names)
1563+
table_name_set = sorted(set(table_names))
15641564
if len(table_name_set) == 1:
15651565
return next(iter(table_name_set))
15661566
return f"<{len(table_name_set)} tables>: {table_name_set}"

fbgemm_gpu/setup.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
# This source code is licensed under the BSD-style license found in the
55
# LICENSE file in the root directory of this source tree.
66

7-
# @licenselint-loose-mode
8-
97
import argparse
108
import logging
119
import os
@@ -655,7 +653,7 @@ def main(argv: list[str]) -> None:
655653
]
656654
+ [
657655
f"Programming Language :: Python :: {x}"
658-
for x in ["3", "3.9", "3.10", "3.11", "3.12", "3.13"]
656+
for x in ["3", "3.10", "3.11", "3.12", "3.13"]
659657
],
660658
)
661659

fbgemm_gpu/test/tbe/utils/split_embeddings_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -178,17 +178,17 @@ def test_get_table_name_for_logging(self) -> None:
178178
SplitTableBatchedEmbeddingBagsCodegen.get_table_name_for_logging(
179179
["t1", "t2"]
180180
),
181-
"<2 tables>: {'t1', 't2'}",
181+
"<2 tables>: ['t1', 't2']",
182182
)
183183
self.assertEqual(
184184
SplitTableBatchedEmbeddingBagsCodegen.get_table_name_for_logging(
185185
["t1", "t2", "t1"]
186186
),
187-
"<2 tables>: {'t1', 't2'}",
187+
"<2 tables>: ['t1', 't2']",
188188
)
189189
self.assertEqual(
190190
SplitTableBatchedEmbeddingBagsCodegen.get_table_name_for_logging([]),
191-
"<0 tables>: set()",
191+
"<0 tables>: []",
192192
)
193193

194194
@unittest.skipIf(*gpu_unavailable)

0 commit comments

Comments
 (0)