Merge pull request #504 from erlend-aasland/fix-examples

Fix comment and assertions in synchronous_client.py

Author: dhoomakethu

examples/common/synchronous_client.py

@@ -14,7 +14,7 @@
         print result
 """
 # --------------------------------------------------------------------------- #
-# import the various server implementations
+# import the various client implementations
 # --------------------------------------------------------------------------- #
 from pymodbus.client.sync import ModbusTcpClient as ModbusClient
 # from pymodbus.client.sync import ModbusUdpClient as ModbusClient
@@ -104,12 +104,13 @@ def run_sync_client():
     rq = client.write_coil(0, True, unit=UNIT)
     rr = client.read_coils(0, 1, unit=UNIT)
     assert(not rq.isError())     # test that we are not an error
+    assert(not rr.isError())     # test that we are not an error
     assert(rr.bits[0] == True)          # test the expected value
 
     log.debug("Write to multiple coils and read back- test 1")
     rq = client.write_coils(1, [True]*8, unit=UNIT)
-    assert(not rq.isError())     # test that we are not an error
     rr = client.read_coils(1, 21, unit=UNIT)
+    assert(not rq.isError())     # test that we are not an error
     assert(not rr.isError())     # test that we are not an error
     resp = [True]*21
 
@@ -124,27 +125,30 @@ def run_sync_client():
     rq = client.write_coils(1, [False]*8, unit=UNIT)
     rr = client.read_coils(1, 8, unit=UNIT)
     assert(not rq.isError())     # test that we are not an error
+    assert(not rr.isError())     # test that we are not an error
     assert(rr.bits == [False]*8)         # test the expected value
 
     log.debug("Read discrete inputs")
     rr = client.read_discrete_inputs(0, 8, unit=UNIT)
-    assert(not rq.isError())     # test that we are not an error
+    assert(not rr.isError())     # test that we are not an error
 
     log.debug("Write to a holding register and read back")
     rq = client.write_register(1, 10, unit=UNIT)
     rr = client.read_holding_registers(1, 1, unit=UNIT)
     assert(not rq.isError())     # test that we are not an error
+    assert(not rr.isError())     # test that we are not an error
     assert(rr.registers[0] == 10)       # test the expected value
 
     log.debug("Write to multiple holding registers and read back")
     rq = client.write_registers(1, [10]*8, unit=UNIT)
     rr = client.read_holding_registers(1, 8, unit=UNIT)
     assert(not rq.isError())     # test that we are not an error
+    assert(not rr.isError())     # test that we are not an error
     assert(rr.registers == [10]*8)      # test the expected value
 
     log.debug("Read input registers")
     rr = client.read_input_registers(1, 8, unit=UNIT)
-    assert(not rq.isError())     # test that we are not an error
+    assert(not rr.isError())     # test that we are not an error
 
     arguments = {
         'read_address':    1,
@@ -156,6 +160,7 @@ def run_sync_client():
     rq = client.readwrite_registers(unit=UNIT, **arguments)
     rr = client.read_holding_registers(1, 8, unit=UNIT)
     assert(not rq.isError())     # test that we are not an error
+    assert(not rr.isError())     # test that we are not an error
     assert(rq.registers == [20]*8)      # test the expected value
     assert(rr.registers == [20]*8)      # test the expected value