(maint) Drop Metrics/AbcSize

It's mostly useless, disable it.

Author: joshcooper

.rubocop.yml

@@ -13,6 +13,8 @@ require:
 
 Layout/LineLength:
   Max: 120
+  Exclude:
+    - spec/facter/resolvers/gce_spec.rb
 
 Lint/RaiseException:
   Enabled: true
@@ -51,25 +53,7 @@ Naming/ClassAndModuleCamelCase:
     - 'spec/mocks/**/*'
 
 Metrics/AbcSize:
-  Max: 16
-  Exclude:
-    - 'spec/custom_facts/util/parser_spec.rb'
-    - 'spec/custom_facts/core/logging_spec.rb'
-    - 'lib/facter/custom_facts/util/values.rb'
-    - 'lib/facter/custom_facts/util/loader.rb'
-    - 'lib/facter/custom_facts/util/confine.rb'
-    - 'lib/facter/custom_facts/util/confine.rb'
-    - 'lib/facter/custom_facts/core/execution/windows.rb'
-    - 'lib/facter/custom_facts/core/execution/base.rb'
-    - 'lib/facter/custom_facts/core/resolvable.rb'
-    - 'lib/facter/resolvers/bsd/ffi/ffi_helper.rb'
-    - 'install.rb'
-    - 'scripts/generate_changelog.rb'
-    - 'lib/facter/resolvers/aix/ffi/ffi_helper.rb'
-    - 'lib/facter/custom_facts/core/execution/popen3.rb'
-    - 'lib/facter.rb'
-    - 'lib/facter/framework/parsers/query_parser.rb'
-    - 'lib/facter/framework/core/fact_manager.rb'
+  Enabled: false
 
 Metrics/PerceivedComplexity:
   Exclude:

lib/facter/resolvers/freebsd/swap_memory.rb

@@ -13,7 +13,7 @@ def post_resolve(fact_name, _options)
             @fact_list.fetch(fact_name) { read_swap_memory(fact_name) }
           end
 
-          def read_swap_memory(fact_name) # rubocop:disable Metrics/AbcSize
+          def read_swap_memory(fact_name)
             output = Facter::Core::Execution.execute('swapinfo -k', logger: log)
             data = output.split("\n")[1..-1].map { |line| line.split(/\s+/) }
 

lib/facter/resolvers/macosx/swap_memory.rb

@@ -13,7 +13,7 @@ def post_resolve(fact_name, _options)
             @fact_list.fetch(fact_name) { read_swap_memory(fact_name) }
           end
 
-          def read_swap_memory(fact_name) # rubocop:disable Metrics/AbcSize
+          def read_swap_memory(fact_name)
             output = Facter::Core::Execution.execute('sysctl -n vm.swapusage', logger: log)
             data = output.match(/^total = ([\d.]+)M  used = ([\d.]+)M  free = ([\d.]+)M  (\(encrypted\))$/)
 

lib/facter/resolvers/solaris/mountpoints.rb

@@ -21,7 +21,7 @@ def exclude_auto_home_mounts!
             end
           end
 
-          def read_mounts(fact_name) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+          def read_mounts(fact_name) # rubocop:disable Metrics/MethodLength
             @mounts = []
             @auto_home_paths = []
 

lib/facter/util/api_debugger.rb

@@ -3,7 +3,7 @@
 module Facter
   module Util
     module ApiDebugger
-      def self.prepended(receiver) # rubocop:disable Metrics/AbcSize
+      def self.prepended(receiver)
         exclude, print_caller = parse_options(ENV['API_DEBUG'])
 
         receiver_methods = receiver.instance_methods - Object.methods

lib/facter/util/resolvers/ffi/hostname.rb

@@ -36,7 +36,7 @@ def self.getffihostname
             raw_hostname.read_string
           end
 
-          def self.getffiaddrinfo(hostname) # rubocop:disable  Metrics/AbcSize
+          def self.getffiaddrinfo(hostname)
             ret = FFI::MemoryPointer.new(:pointer)
 
             hints = Facter::Util::Resolvers::Ffi::AddrInfo.new