Change return type of listFiles() from Path[] to List<Path>

Signed-off-by: Ben Sherman <[email protected]>

Author: bentsherman

modules/nf-commons/src/main/nextflow/extension/FilesEx.groovy

@@ -625,8 +625,8 @@ class FilesEx {
      * @param self The folder to list
      * @return A list of strings or {@code null} if the path is not a folder
      */
-    static String[] list(Path self) {
-        listFiles(self).collect { getName(it) } as String[]
+    static List<String> list(Path self) {
+        return listFiles(self).collect { getName(it) }
     }
 
     /**
@@ -636,12 +636,13 @@ class FilesEx {
      * @param self The folder to list
      * @return A list of {@code Path} or {@code null} if the path is not a folder
      */
-    static Path[] listFiles(Path self, @ClosureParams(value = FromString.class, options = ["java.nio.file.Path", "java.nio.file.Path,java.nio.file.attribute.BasicFileAttributes"]) Closure<Boolean> filter=null) {
+    static List<Path> listFiles(Path self, @ClosureParams(value = FromString.class, options = ["java.nio.file.Path", "java.nio.file.Path,java.nio.file.attribute.BasicFileAttributes"]) Closure<Boolean> filter=null) {
 
         if( !self.isDirectory() )
             return null
 
-        def result = []
+        final result = []
+
         Files.walkFileTree(self, new SimpleFileVisitor<Path>() {
 
             FileVisitResult visitFile(Path file, BasicFileAttributes attrs) {
@@ -651,19 +652,17 @@ class FilesEx {
             }
 
             FileVisitResult preVisitDirectory(Path dir, BasicFileAttributes attrs) {
-                if( self == dir )
+                if( self == dir ) {
                     FileVisitResult.CONTINUE
-
+                }
                 else {
                     result.add(dir)
                     FileVisitResult.SKIP_SUBTREE
                 }
             }
-
         } )
 
-        return result as Path[]
-
+        return result
     }
 
     @CompileStatic