chore: minor renaming

Author: nader-zouaoui

parser-tests/parser-tests.cpp

@@ -108,8 +108,7 @@ namespace parsertests
             parser.parse(argc, argv);
 
             Assert::IsTrue(parser.do_record.get());
-            Assert::AreEqual(std::wstring(L"notepad.exe test_arg"), parser.record_commandline.get());
-            Assert::AreEqual(std::wstring(L"notepad.exe"), parser.sample_pe_file.get());
+            Assert::AreEqual(std::wstring(L"notepad.exe test_arg"), parser.double_dash.get());
             Assert::IsTrue(COMMAND_CLASS::RECORD == parser.command);
         }
 

parser/arg-parser.cpp

@@ -80,9 +80,9 @@ void arg_parser::parse(
         }
 
         // Parse the extra arguments after the "--" flag 
-        if (try_match_arg(raw_args, record_commandline)) {
+        if (try_match_arg(raw_args, double_dash)) {
             raw_args.erase(raw_args.begin());
-            parse_record_commandline(raw_args);
+            parse_command_after_double_dash(raw_args);
             break;
         }
 
@@ -95,19 +95,18 @@ void arg_parser::parse(
 }
 
 #pragma region command line parsing after "--"
-void arg_parser::parse_record_commandline(wstr_vec& raw_args_vect)
+void arg_parser::parse_command_after_double_dash(wstr_vec& raw_args_vect)
 {
     while (raw_args_vect.size() > 0)
     {
         wstring arg = raw_args_vect.front();
 
-        if (sample_pe_file.value.empty())
+        if (double_dash.value.empty())
         {
-            sample_pe_file.value = arg;
-            record_commandline.value = arg;
+            double_dash.value = arg;
         }
         else {
-            record_commandline.value += L" " + arg;
+            double_dash.value += L" " + arg;
         }
         raw_args_vect.erase(raw_args_vect.begin());
     }

parser/arg-parser.h

@@ -233,7 +233,7 @@ class arg_parser
 #pragma endregion
 
 #pragma region Flags with arguments
-    flag_with_argument record_commandline = {
+    flag_with_argument double_dash = {
       L"--",
       L"",
       L"-- Process name is defined by COMMAND. User can pass verbatim arguments to the process with[ARGS].",
@@ -431,7 +431,7 @@ class arg_parser
 
 #pragma region Private Methods
 private:
-    void parse_record_commandline(wstr_vec& raw_args_vect);
+    void parse_command_after_double_dash(wstr_vec& raw_args_vect);
     bool try_match_and_set_arg(wstr_vec& raw_args_vect, arg_type& flag);
     bool try_match_and_set_arg(wstr_vec& raw_args_vect, flag_bool_type& flag);
     bool try_match_and_set_arg(wstr_vec& raw_args_vect, flag_with_argument& flag);