[assert] Remove dependency on Register implementation

This caused issues with circular imports and it is not necessary to have.

Author: salkinium

ext/gcc/assert.cpp.in

@@ -11,7 +11,6 @@
 
 #include <cstdint>
 #include <bits/functexcept.h>
-#include <modm/math/utils/bit_constants.hpp>
 
 %% if options["assert_on_exception"]
 #include <modm/architecture/interface/assert.hpp>

src/modm/architecture/interface/assert.hpp.in

@@ -12,7 +12,6 @@
 #pragma once
 
 #include "assert.h"
-#include <modm/architecture/interface/register.hpp>
 %% if core.startswith("avr")
 #include <modm/architecture/interface/accessor_flash.hpp>
 %% endif
@@ -27,13 +26,13 @@ namespace modm
 enum class
 Abandonment : uint8_t
 {
-	DontCare = Bit0,	///< Do not care about failure.
-	Ignore = Bit1,		///< Ignore this failure.
-	Fail = Bit2,		///< This failure is reason for abandonment.
-	Debug = Bit7		///< Only set for a debug-only failure.
+	DontCare = 0b001,	///< Do not care about failure.
+	Ignore = 0b010,		///< Ignore this failure.
+	Fail = 0b100,		///< This failure is reason for abandonment.
+	Debug = 0x80,		///< Only set for a debug-only failure.
 };
-using AbandonmentBehavior = Flags8<Abandonment>;
-MODM_TYPE_FLAGS(AbandonmentBehavior);
+/// Contains the superset of Abandonment behavior
+using AbandonmentBehavior = Abandonment;
 
 /// Contains information about the failed assertion.
 struct modm_packed

src/modm/architecture/module.lb

@@ -53,7 +53,6 @@ class Assert(Module):
                               default="release" if platform == "hosted" else "debug",
                               enumeration=["off", "debug", "release"]))
 
-        module.depends(":architecture:register")
         if platform == "avr":
             module.depends(":architecture:accessor")
         return True

src/modm/driver/color/tcs3472.hpp

@@ -17,6 +17,7 @@
 
 #include <stdint.h>
 #include <modm/architecture/interface/i2c_device.hpp>
+#include <modm/architecture/interface/register.hpp>
 #include <modm/math/utils.hpp>
 #include <modm/ui/color.hpp>
 

src/modm/driver/color/tcs3472.lb

@@ -19,6 +19,7 @@ def init(module):
 def prepare(module, options):
     module.depends(
         ":architecture:i2c.device",
+        ":architecture:register",
         ":ui:color",
         ":math:utils")
     return True

src/modm/driver/display/st7586s.lb

@@ -18,6 +18,7 @@ def init(module):
 def prepare(module, options):
     module.depends(
         ":architecture:fiber",
+        ":architecture:register",
         ":ui:display")
     return True
 

src/modm/driver/display/st7586s_protocol.hpp

@@ -11,6 +11,7 @@
 
 #pragma once
 
+#include <modm/architecture/interface/register.hpp>
 #include <modm/math/utils/endianness.hpp>
 
 /// @cond

src/modm/platform/adc/at90_tiny_mega/module.lb

@@ -27,6 +27,7 @@ def prepare(module, options):
 
     module.depends(
         ":architecture:adc",
+        ":architecture:register",
         ":architecture:interrupt",
         ":platform:gpio",
         ":math:algorithm")

src/modm/platform/can/common/fdcan/module.lb

@@ -21,6 +21,7 @@ def prepare(module, options):
 
     module.depends(
         ":architecture:assert",
+        ":architecture:register",
         ":architecture:can",
         ":architecture:clock")
     return True

src/modm/platform/core/cortex/assert.cpp.in

@@ -57,22 +57,22 @@ void
 modm_assert_report(_modm_assertion_info *cinfo)
 {
 	auto info = reinterpret_cast<modm::AssertionInfo *>(cinfo);
-	AbandonmentBehavior behavior(info->behavior);
+	uint8_t behavior(uint8_t(info->behavior));
 
 	for (const AssertionHandler *handler = &__assertion_table_start;
 		 handler < &__assertion_table_end; handler++)
 	{
 %% if core.startswith("avr")
-		behavior |= ((AssertionHandler)pgm_read_ptr(handler))(*info);
+		behavior |= (uint8_t)((AssertionHandler)pgm_read_ptr(handler))(*info);
 %% else
-		behavior |= (*handler)(*info);
+		behavior |= (uint8_t)(*handler)(*info);
 %% endif
 	}
 
-	info->behavior = behavior;
-	behavior.reset(Abandonment::Debug);
-	if ((behavior == Abandonment::DontCare) or
-		(behavior & Abandonment::Fail))
+	info->behavior = AbandonmentBehavior(behavior);
+	behavior &= ~uint8_t(Abandonment::Debug);
+	if ((behavior == uint8_t(Abandonment::DontCare)) or
+		(behavior & uint8_t(Abandonment::Fail)))
 	{
 		modm_abandon(*info);
 %% if core.startswith("cortex-m")