Skip to content

Commit 9025cc8

Browse files
committed
Address @tavianator
1 parent 00ebb80 commit 9025cc8

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

textworld/generator/dependency_tree.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def __init__(self, element: DependencyTreeElement):
4949
def push(self, node: "DependencyTree._Node") -> bool:
5050
if node == self:
5151
return True
52-
52+
5353
added = False
5454
for child in self.children:
5555
added |= child.push(node)
@@ -74,11 +74,11 @@ def already_added(self, node: "DependencyTree._Node") -> bool:
7474
return True
7575

7676
return False
77-
77+
7878
def __iter__(self) -> Iterable["DependencyTree._Node"]:
7979
for child in self.children:
8080
yield from list(child)
81-
81+
8282
yield self
8383

8484
def __str__(self) -> str:
@@ -99,7 +99,7 @@ def copy(self) -> "DependencyTree._Node":
9999

100100
return node
101101

102-
def __init__(self, element_type: DependencyTreeElement = DependencyTreeElement, trees: Iterable["DependencyTree"] = []):
102+
def __init__(self, element_type: type = DependencyTreeElement, trees: Iterable["DependencyTree"] = []):
103103
self.roots = []
104104
self.element_type = element_type
105105
for tree in trees:
@@ -110,25 +110,25 @@ def __init__(self, element_type: DependencyTreeElement = DependencyTreeElement,
110110
def push(self, value: Any, allow_multi_root: bool = False) -> bool:
111111
""" Add a value to this dependency tree.
112112
113-
Adding a value already present in the tree does not modify the tree.
114-
113+
Adding a value already present in the tree does not modify the tree.
114+
115115
Args:
116116
value: value to add.
117-
allow_multi_root: if `True`, allow the value to spawn an
117+
allow_multi_root: if `True`, allow the value to spawn an
118118
additional root if needed.
119-
119+
120120
"""
121121
element = self.element_type(value)
122122
node = DependencyTree._Node(element)
123-
123+
124124
added = False
125125
for root in self.roots:
126126
added |= root.push(node)
127127

128128
if len(self.roots) == 0 or (not added and allow_multi_root):
129129
self.roots.append(node)
130130
added = True
131-
131+
132132
self._update() # Recompute leaves.
133133
return added
134134

@@ -137,17 +137,17 @@ def remove(self, value: Any) -> None:
137137
138138
The value to remove needs to belong to at least one leaf in this tree.
139139
Otherwise, the tree remains unchanged.
140-
140+
141141
Args:
142142
value: value to remove from the tree.
143-
143+
144144
Returns:
145145
Whether the tree has changed or not.
146146
"""
147147
if value not in self.leaves_values:
148148
return False
149149

150-
root_to_remove = []
150+
root_to_remove = []
151151
for node in self:
152152
if node.element.value == value:
153153
if node.parent is not None:
@@ -160,7 +160,7 @@ def remove(self, value: Any) -> None:
160160

161161
self._update() # Recompute leaves.
162162
return True
163-
163+
164164
def _update(self) -> None:
165165
self._leaves_values = []
166166
self._leaves_elements = []
@@ -177,7 +177,7 @@ def copy(self) -> "DependencyTree":
177177
tree = type(self)(element_type=self.element_type)
178178
for root in self.roots:
179179
tree.roots.append(root.copy())
180-
180+
181181
tree._update()
182182
return tree
183183

0 commit comments

Comments
 (0)