Cosmetic modifications to [GTRepository shouldIgnoreFileURL:error:] based on feedback

onecrayon · onecrayon · commit 4ad06b8f4061 · 2016-01-28T20:12:12.000-08:00
diff --git a/ObjectiveGit/GTRepository+Status.m b/ObjectiveGit/GTRepository+Status.m
@@ -126,9 +126,12 @@ - (BOOL)shouldFileBeIgnored:(NSURL *)fileURL success:(BOOL *)success error:(NSEr
 }
 
 - (GTFileIgnoreState)shouldIgnoreFileURL:(NSURL *)fileURL error:(NSError **)error {
-	BOOL success = false;
+	BOOL success = NO;
 	BOOL ignore = [self shouldFileBeIgnored:fileURL success:&success error:error];
-	return ignore && success ? GTFileIgnoreStateShouldIgnore : (!ignore && success ? GTFileIgnoreStateShouldNotIgnore : GTFileIgnoreStateIgnoreCheckFailed);
+	if (success) {
+		return (ignore ? GTFileIgnoreStateShouldIgnore : GTFileIgnoreStateShouldNotIgnore);
+	}
+	return GTFileIgnoreStateIgnoreCheckFailed;
 }
 
 @end

Original file line number	Diff line number	Diff line change
`@@ -126,9 +126,12 @@ - (BOOL)shouldFileBeIgnored:(NSURL )fileURL success:(BOOL )success error:(NSEr`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`- (GTFileIgnoreState)shouldIgnoreFileURL:(NSURL )fileURL error:(NSError *)error {`
`129`		`- BOOL success = false;`
	`129`	`+ BOOL success = NO;`
`130`	`130`	`BOOL ignore = [self shouldFileBeIgnored:fileURL success:&success error:error];`
`131`		`- return ignore && success ? GTFileIgnoreStateShouldIgnore : (!ignore && success ? GTFileIgnoreStateShouldNotIgnore : GTFileIgnoreStateIgnoreCheckFailed);`
	`131`	`+ if (success) {`
	`132`	`+ return (ignore ? GTFileIgnoreStateShouldIgnore : GTFileIgnoreStateShouldNotIgnore);`
	`133`	`+ }`
	`134`	`+ return GTFileIgnoreStateIgnoreCheckFailed;`
`132`	`135`	`}`
`133`	`136`
`134`	`137`	`@end`