Skip to content

Commit dc30fe8

Browse files
Apply suggestions from code review
Co-authored-by: Erik Sundell <[email protected]>
1 parent 02d49b3 commit dc30fe8

File tree

2 files changed

+13
-15
lines changed

2 files changed

+13
-15
lines changed

_static/link_gen/link.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ function generateRegularUrl(hubUrl, urlPath, repoUrl, branch, compressed, conten
66

77
url.searchParams.set('repo', repoUrl);
88
if(compressed) {
9-
url.searchParams.set('content_provider', contentProvider);
9+
url.searchParams.set('content_provider', contentProvider);
1010
}
1111
if (urlPath) {
1212
url.searchParams.set('urlpath', urlPath);
@@ -34,7 +34,7 @@ function generateCanvasUrl(hubUrl, urlPath, repoUrl, branch, compressed, content
3434

3535
nextUrlParams.append('repo', repoUrl);
3636
if(compressed) {
37-
nextUrlParams.append('content_provider', contentProvider);
37+
nextUrlParams.append('content_provider', contentProvider);
3838
}
3939
if (urlPath) {
4040
nextUrlParams.append('urlpath', urlPath);
@@ -67,7 +67,7 @@ function generateBinderUrl(hubUrl, userName, envRepoName, envGitBranch, urlPath,
6767
nextUrlParams.append('repo', contentGitRepoUrl);
6868

6969
if(compressed) {
70-
nextUrlParams.append('content_provider', contentProvider);
70+
nextUrlParams.append('content_provider', contentProvider);
7171
}
7272
if (urlPath) {
7373
nextUrlParams.append('urlpath', urlPath);
@@ -199,9 +199,9 @@ function configureContentProviderAttrs(args){
199199
contentProviderURL = args["webUrl"];
200200
}
201201
return {
202-
"branch": branch,
203-
"contentProviderURL": contentProviderURL,
204-
"compressed": compressed
202+
"branch": branch,
203+
"contentProviderURL": contentProviderURL,
204+
"compressed": compressed
205205
}
206206
}
207207

@@ -235,12 +235,12 @@ function displayLink() {
235235
var urlPath = apps[appName].generateUrlPath(partialUrlPath);
236236
}
237237
args = {
238-
"contentProvider": contentProvider,
239-
"contentGitRepoUrl": contentGitRepoUrl,
240-
"contentGitRepoBranch": contentGitRepoBranch,
241-
"driveUrl": driveUrl,
242-
"dropUrl": dropUrl,
243-
"webUrl": webUrl
238+
"contentProvider": contentProvider,
239+
"contentGitRepoUrl": contentGitRepoUrl,
240+
"contentGitRepoBranch": contentGitRepoBranch,
241+
"driveUrl": driveUrl,
242+
"dropUrl": dropUrl,
243+
"webUrl": webUrl
244244
}
245245
config = configureContentProviderAttrs(args)
246246
if (activeTab === "tab-auth-default") {

link.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -357,9 +357,7 @@ <h1>nbgitpuller link generator<a class="headerlink" href="#nbgitpuller-link-gene
357357

358358
<div class="form-group row" id="app-container">
359359
<div class="col-sm-2 col-form-label">
360-
<label for="app-container" class=>Application to Open</label>
361-
<small class="form-text text-muted">
362-
</small>
360+
<label>Application to Open</label>
363361
</div>
364362
<div class="col-sm-10">
365363
<div class="form-check">

0 commit comments

Comments
 (0)