File tree Expand file tree Collapse file tree 4 files changed +10
-2
lines changed Expand file tree Collapse file tree 4 files changed +10
-2
lines changed Original file line number Diff line number Diff line change @@ -135,6 +135,7 @@ - (void)closeView
135135{
136136 [[NSNotificationCenter defaultCenter ] removeObserver: self ];
137137 [webController closeView ];
138+ [super closeView ];
138139}
139140
140141- (NSResponder *)firstResponder ;
Original file line number Diff line number Diff line change @@ -125,6 +125,11 @@ - (void)awakeFromNib
125125 [[NSNotificationCenter defaultCenter ] addObserver: self selector: @selector (expandCollapseItem: ) name: NSOutlineViewItemWillCollapseNotification object: sourceView];
126126}
127127
128+ - (void )closeView
129+ {
130+ [super closeView ];
131+ }
132+
128133- (void )dealloc
129134{
130135 [[NSNotificationCenter defaultCenter ] removeObserver: self name: NSOutlineViewItemWillExpandNotification object: sourceView];
Original file line number Diff line number Diff line change @@ -35,7 +35,9 @@ - (void)closeView
3535{
3636 [self unbind: @" repository" ];
3737 if (_hasViewLoaded)
38- [[self view ] removeFromSuperview ]; // remove the current view
38+ [[self view ] removeFromSuperview ]; // remove the current view
39+ repository = nil ;
40+ superController = nil ;
3941}
4042
4143- (void )awakeFromNib
Original file line number Diff line number Diff line change @@ -40,7 +40,7 @@ NS_ASSUME_NONNULL_BEGIN
4040@property (getter =isUncollapsible) BOOL uncollapsible;
4141@property (getter =isExpanded) BOOL expanded;
4242@property PBGitRevSpecifier *revSpecifier;
43- @property PBSourceViewItem *parent;
43+ @property ( weak ) PBSourceViewItem *parent;
4444@property (readonly ) NSString *iconName;
4545@property (nullable , readonly ) NSImage *icon;
4646
You can’t perform that action at this time.
0 commit comments