lint check

Author: mengfei25

.github/ci_expected_accuracy/check_expected.py

@@ -66,7 +66,7 @@ def parse_file_name(filename):
 def load_known_data(issue_file):
     """Load known test data from JSON file."""
     try:
-        with open(issue_file, 'r', encoding='utf-8') as file:
+        with open(issue_file, encoding='utf-8') as file:
             return json.load(file)
     except (FileNotFoundError, json.JSONDecodeError) as e:
         print(f"Error loading known data from {issue_file}: {e}")
@@ -91,8 +91,7 @@ def update_reference_dataframe(refer_data, model_name, dtype, accuracy):
         refer_data.loc[mask, dtype] = accuracy
     else:
         new_row = {'name': model_name, dtype: accuracy}
-        refer_data = pd.concat([refer_data, pd.DataFrame([new_row])],
-                              ignore_index=True)
+        refer_data = pd.concat([refer_data, pd.DataFrame([new_row])], ignore_index=True)
     return refer_data
 
 
@@ -155,22 +154,14 @@ def main():
         description="Accuracy Check",
         formatter_class=argparse.ArgumentDefaultsHelpFormatter
     )
-    parser.add_argument("--driver", type=str, default="rolling",
-                       help="rolling or lts")
-    parser.add_argument("--category", type=str, default="inductor",
-                       help="inductor")
-    parser.add_argument("--suite", type=str, required=True,
-                       help="huggingface, timm_models or torchbench")
-    parser.add_argument("--mode", type=str, required=True,
-                       help="inference or training")
-    parser.add_argument("--dtype", type=str, required=True,
-                       help="float32, bfloat16, float16, amp_bf16 or amp_fp16")
-    parser.add_argument("--csv_file", type=str, required=True,
-                       help="Test results CSV file path")
-    parser.add_argument("--issue_file", type=str, required=True,
-                       help="Known test data JSON file path")
-    parser.add_argument('--update', action='store_true',
-                       help="Whether to update new pass and new failed info")
+    parser.add_argument("--driver", type=str, default="rolling", help="rolling or lts")
+    parser.add_argument("--category", type=str, default="inductor", help="inductor")
+    parser.add_argument("--suite", type=str, required=True, help="huggingface, timm_models or torchbench")
+    parser.add_argument("--mode", type=str, required=True, help="inference or training")
+    parser.add_argument("--dtype", type=str, required=True, help="float32, bfloat16, float16, amp_bf16 or amp_fp16")
+    parser.add_argument("--csv_file", type=str, required=True, help="Test results CSV file path")
+    parser.add_argument("--issue_file", type=str, required=True, help="Known test data JSON file path")
+    parser.add_argument('--update', action='store_true', help="Whether to update new pass and new failed info")
 
     args = parser.parse_args()
 

.github/scripts/e2e_summary.sh

@@ -5,9 +5,10 @@ set -euo pipefail
 # Script: test_results_processor.sh
 # Description: Process accuracy and performance test results for XPU operations
 
-readonly script_path="$(dirname "${BASH_SOURCE[0]}")"
-readonly SCRIPT_DIR="$(cd "$script_path" && pwd)"
-readonly SCRIPT_NAME="$(basename "$0")"
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+readonly SCRIPT_DIR
+SCRIPT_NAME="$(basename "$0")"
+readonly SCRIPT_NAME
 
 # Constants
 readonly RED='🔴'

.github/scripts/lintrunner.sh

@@ -2,8 +2,10 @@
 set -ex
 
 # Creat a venv for lint check
-curl -LsSf https://astral.sh/uv/install.sh | sh
-source $HOME/.local/bin/env
+if ! uv --help > /dev/null 2>&1; then
+    curl -LsSf https://astral.sh/uv/install.sh | sh
+    export PATH="$PATH:$HOME/.local/bin"
+fi
 uv venv lint --python 3.12 --clear
 source lint/bin/activate
 uv pip install -U pip setuptools wheel
@@ -25,7 +27,7 @@ if ! command -v lintrunner &> /dev/null; then
 fi
 
 # Ignoring errors in one specific run
-export SHELLCHECK_OPTS="-e SC2154 -e SC2086 -e SC1091 -e SC2046 -e SC2076 -e SC2034"
+export SHELLCHECK_OPTS="-e SC2154 -e SC2086 -e SC1091 -e SC2046 -e SC2076 -e SC2034 -e SC2190"
 
 # This has already been cached in the docker image
 lintrunner init 2> /dev/null