don't reset connections just cause an accessory was added or removed

the caller is expected to updated the configuration index, at which
point iOS will shortly request the new accessory information.

Author: ccutrer

CHANGES.md

@@ -1,3 +1,6 @@
+# HAP-Java 2.0.3
+* Avoid unnecessary forced disconnects. Library users should be updating the configuration index anyway.
+
 # HAP-Java 2.0.2
  * Various minor stability issues for after an accessory has been removed.
 

src/main/java/io/github/hapjava/server/impl/HomekitRoot.java

@@ -112,7 +112,6 @@ void addAccessorySkipRangeCheck(HomekitAccessory accessory) {
     }
     if (started) {
       registry.reset();
-      webHandler.resetConnections();
     }
   }
 
@@ -130,7 +129,6 @@ public void removeAccessory(HomekitAccessory accessory) {
     }
     if (started) {
       registry.reset();
-      webHandler.resetConnections();
     }
   }
 

src/test/java/io/github/hapjava/server/impl/HomekitRootTest.java

@@ -91,20 +91,18 @@ public void testAdvertiserStops() throws Exception {
   }
 
   @Test
-  public void testAddAccessoryResetsWeb() {
+  public void testAddAccessoryDoesntResetWeb() {
     root.start();
-    verify(webHandler, never()).resetConnections();
     root.addAccessory(accessory);
-    verify(webHandler).resetConnections();
+    verify(webHandler, never()).resetConnections();
   }
 
   @Test
-  public void testRemoveAccessoryResetsWeb() {
+  public void testRemoveAccessoryDoesntResetWeb() {
     root.addAccessory(accessory);
     root.start();
-    verify(webHandler, never()).resetConnections();
     root.removeAccessory(accessory);
-    verify(webHandler).resetConnections();
+    verify(webHandler, never()).resetConnections();
   }
 
   @Test(expected = IndexOutOfBoundsException.class)