Skip to content

Commit c84934d

Browse files
committed
chore: revert click submit changes
1 parent 239dfff commit c84934d

File tree

5 files changed

+3
-25
lines changed

5 files changed

+3
-25
lines changed

src/constants.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ export const EVENT_KEYBOARD_SHORTCUTS = {
1313
toggleAutoSubmit: (event: KeyboardEvent) =>
1414
event.ctrlKey && event.code === 'KeyO',
1515
toggleWidgetVisibility: (event: KeyboardEvent) =>
16-
event.ctrlKey && event.code === 'KeyX',
17-
clickSubmit: (event: KeyboardEvent) => event.ctrlKey && event.code === 'KeyM'
16+
event.ctrlKey && event.code === 'KeyX'
1817
} as const
1918

2019
export const EVENT_KEYBOARD_SHORTCUTS_HELP = `

src/features/keyboard-listeners.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,5 @@ export function setKeyboardListeners(): void {
3434
event.preventDefault()
3535
toggleWidgetVisibility()
3636
}
37-
38-
if (EVENT_KEYBOARD_SHORTCUTS.clickSubmit(event)) {
39-
event.preventDefault()
40-
submitButton.getSubmitButton()?.click()
41-
}
4237
})
4338
}

src/features/submit-button.ts

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,10 @@
1-
import { createSignal } from 'solid-js'
2-
31
import { logger } from '../utils/logger.js'
42
import { toggleAutoSubmit } from './widget/auto-submit-button.js'
53

64
const SUBMIT_BUTTON_SELECTOR = '.btn-success'
75
const SUBMIT_BUTTON_TEXT = 'Submit Rating'
86

9-
const [autoSubmitting, setAutoSubmitting] = createSignal(true)
10-
117
class SubmitButton {
12-
get isAutoSubmit(): boolean {
13-
return autoSubmitting()
14-
}
15-
16-
toggleAutoSubmit(): void {
17-
setAutoSubmitting(!autoSubmitting())
18-
}
19-
208
getSubmitButton(): HTMLButtonElement | null {
219
const buttons = Array.from(
2210
document.querySelectorAll(SUBMIT_BUTTON_SELECTOR)
@@ -33,7 +21,7 @@ class SubmitButton {
3321
}
3422

3523
clickSubmit(): void {
36-
if (toggleAutoSubmit.isAutoSubmit) return
24+
if (toggleAutoSubmit.isEnabled) return
3725

3826
const submitButton = this.getSubmitButton()
3927
if (!submitButton) {

src/features/tasks/task-fields-observer.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,6 @@ class TaskFieldsObserver {
7171
estimated: estimatedTimeOffset
7272
})
7373

74-
if (!toggleAutoSubmit.isAutoSubmit) {
75-
toggleAutoSubmit.toggle()
76-
}
77-
7874
if (this.taskFields) {
7975
logger.info('Task is submitted', this.taskFields)
8076
storage.write({

src/features/widget/auto-submit-button.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { tooltip } from '../../utils/tooltip.js'
66
const [autosubmit, setAutosubmit] = createSignal(true)
77

88
class ToggleAutoSubmit {
9-
get isAutoSubmit(): boolean {
9+
get isEnabled(): boolean {
1010
return autosubmit()
1111
}
1212

0 commit comments

Comments
 (0)