refactor(tinyusb_task): Revert the old way of deleting task when no polling

Author: roma-jam

device/esp_tinyusb/tinyusb_task.c

@@ -100,10 +100,10 @@ static void tinyusb_device_task(void *arg)
         // Non-blocking check to stop the task
         uint32_t notif = 0;
         if (xTaskNotifyWait(
-                    0,                 // don't clear any bits on entry
+                    0,                      // don't clear any bits on entry
                     TASK_NOTIF_STOP_BIT,    // clear STOP bit on exit if it was set
                     &notif,
-                    0                  // no wait; just poll the bit
+                    0                       // no wait; just poll the bit
                 ) == pdTRUE && (notif & TASK_NOTIF_STOP_BIT)) {
             // Stop requested
             stop_in_pending = true;
@@ -112,14 +112,14 @@ static void tinyusb_device_task(void *arg)
         // TinyUSB Device task
         tud_task_ext(2000 /* TODO: make dynamically configurable */, false);
     }
-    
+
     // Stop TinyUSB stack
     if (!tusb_deinit(task_ctx->rhport)) {
         ESP_LOGE(TAG, "Unable to deinit TinyUSB stack");
     }
-    
+
     ESP_LOGD(TAG, "TinyUSB task has stopped");
-    
+
 desc_free:
     tinyusb_descriptors_free();
 del:
@@ -226,24 +226,33 @@ esp_err_t tinyusb_task_stop(void)
     _task_is_pending = true;    // Task is pending to stop
     TINYUSB_TASK_EXIT_CRITICAL();
 
-    /* Request TinyUSB task to stop */
-    if (xTaskNotify(task_ctx->handle, TASK_NOTIF_STOP_BIT, eSetBits) != pdPASS) {
-        ESP_LOGE(TAG, "Unable to notify TinyUSB task to stop");
-        return ESP_ERR_INVALID_STATE;
-    }
+    if (true /* tinyusb task polling time ms != 0 */) {
+        /* Request TinyUSB task to stop */
+        if (xTaskNotify(task_ctx->handle, TASK_NOTIF_STOP_BIT, eSetBits) != pdPASS) {
+            ESP_LOGE(TAG, "Unable to notify TinyUSB task to stop");
+            return ESP_ERR_INVALID_STATE;
+        }
+        /* Wait for "stop" semaphore with timeout */
+        if (xSemaphoreTake(task_ctx->start_stop_sem, pdMS_TO_TICKS(TINYUSB_TASK_SEM_TAKE_TIMEOUT_MS)) != pdTRUE) {
+            ESP_LOGE(TAG, "Timeout while TinyUSB task stop");
+            return ESP_ERR_TIMEOUT;
+        }
 
-    /* Wait for "stop" semaphore with timeout */
-    if (xSemaphoreTake(task_ctx->start_stop_sem, pdMS_TO_TICKS(TINYUSB_TASK_SEM_TAKE_TIMEOUT_MS)) != pdTRUE) {
-        ESP_LOGE(TAG, "Timeout while TinyUSB task stop");
-        return ESP_ERR_TIMEOUT;
+        /* Check the global task context pointer and pending state */
+        TINYUSB_TASK_ENTER_CRITICAL();
+        TINYUSB_TASK_CHECK_FROM_CRIT(!_task_is_pending, ESP_ERR_INVALID_STATE);
+        TINYUSB_TASK_CHECK_FROM_CRIT(p_tusb_task_ctx == NULL, ESP_ERR_INVALID_STATE);
+        TINYUSB_TASK_EXIT_CRITICAL();
+    } else {
+        /* TinyUSB Task is forever loop, delete the task the old way */
+        vTaskDelete(task_ctx->handle);
+        task_ctx->handle = NULL;
+        /* Free descriptors */
+        tinyusb_descriptors_free();
+        /* Deinit TinyUSB Stask */
+        ESP_RETURN_ON_FALSE(tusb_deinit(task_ctx->rhport), ESP_ERR_INVALID_STATE, TAG, "Unable to deinit TinyUSB stack");
     }
 
-    /* Check the global task context pointer and pending state */
-    TINYUSB_TASK_ENTER_CRITICAL();
-    TINYUSB_TASK_CHECK_FROM_CRIT(!_task_is_pending, ESP_ERR_INVALID_STATE);
-    TINYUSB_TASK_CHECK_FROM_CRIT(p_tusb_task_ctx == NULL, ESP_ERR_INVALID_STATE);
-    TINYUSB_TASK_EXIT_CRITICAL();
-
     /* Cleanup */
     vSemaphoreDelete(task_ctx->start_stop_sem);
     heap_caps_free(task_ctx);