lsp-lens: fix overlay location to avoid conflict with lsp-ui-sideline (#4847)

* lsp-lens: fix overlay location to avoid conflict with lsp-ui-sideline

* lsp-lens: fix a failed lsp-lens CI test

Author: taquangtrung

lsp-lens.el

@@ -103,9 +103,10 @@ Results are meaningful only if FROM and TO are on the same line."
   "Find or create a lens for the line at POS."
   (-doto (save-excursion
            (goto-char pos)
-           (if (eq 'end-of-line lsp-lens-place-position)
-               (make-overlay (line-end-position) -1 nil t t)
-             (make-overlay (line-beginning-position) (1+ (line-end-position)) nil t t)))
+           (let ((eol (line-end-position)))
+             (if (eq 'end-of-line lsp-lens-place-position)
+                 (make-overlay eol eol nil t t)
+               (make-overlay (line-beginning-position) (1+ eol) nil t t))))
     (overlay-put 'lsp-lens t)
     (overlay-put 'lsp-lens-position pos)))
 

test/lsp-mock-server-test.el

@@ -862,6 +862,6 @@ line 3 words here and here
        (should (string-match-p "My command"
                                (overlay-get (car lenses) 'after-string)))
        (goto-char (overlay-start (car lenses)))
-       (should (equal (line-number-at-pos) (- line 1)))))))
+       (should (equal (line-number-at-pos) (+ line 1)))))))
 
 ;;; lsp-mock-server-test.el ends here