Skip to content

Commit cdab038

Browse files
Copilotdgageot
andcommitted
Fix unparam linter issue by removing unused name parameter
Co-authored-by: dgageot <[email protected]>
1 parent d87b804 commit cdab038

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pkg/gateway/clientpool_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ command:
263263
`
264264

265265
// Test that global DisableNetwork=true adds --network none
266-
args, env := argsAndEnvWithGlobalDisableNetwork(t, "test-server", catalogYAML, "", nil, nil, true)
266+
args, env := argsAndEnvWithGlobalDisableNetwork(t, catalogYAML, "", nil, nil, true)
267267

268268
assert.Contains(t, args, "--network")
269269
assert.Contains(t, args, "none")
@@ -279,7 +279,7 @@ disableNetwork: false
279279
`
280280

281281
// Test that global DisableNetwork=true overrides server setting
282-
args, env := argsAndEnvWithGlobalDisableNetwork(t, "test-server", catalogYAML, "", nil, nil, true)
282+
args, env := argsAndEnvWithGlobalDisableNetwork(t, catalogYAML, "", nil, nil, true)
283283

284284
assert.Contains(t, args, "--network")
285285
assert.Contains(t, args, "none")
@@ -295,7 +295,7 @@ disableNetwork: true
295295
`
296296

297297
// Test that server DisableNetwork=true works when global is false
298-
args, env := argsAndEnvWithGlobalDisableNetwork(t, "test-server", catalogYAML, "", nil, nil, false)
298+
args, env := argsAndEnvWithGlobalDisableNetwork(t, catalogYAML, "", nil, nil, false)
299299

300300
assert.Contains(t, args, "--network")
301301
assert.Contains(t, args, "none")
@@ -311,7 +311,7 @@ disableNetwork: false
311311
`
312312

313313
// Test that when both global and server DisableNetwork are false, networks are enabled
314-
args, env := argsAndEnvWithGlobalDisableNetwork(t, "test-server", catalogYAML, "", nil, nil, false)
314+
args, env := argsAndEnvWithGlobalDisableNetwork(t, catalogYAML, "", nil, nil, false)
315315

316316
// Should not contain --network none
317317
networkNoneFound := false
@@ -325,7 +325,7 @@ disableNetwork: false
325325
assert.Empty(t, env)
326326
}
327327

328-
func argsAndEnvWithGlobalDisableNetwork(t *testing.T, name, catalogYAML, configYAML string, secrets map[string]string, readOnly *bool, globalDisableNetwork bool) ([]string, []string) {
328+
func argsAndEnvWithGlobalDisableNetwork(t *testing.T, catalogYAML, configYAML string, secrets map[string]string, readOnly *bool, globalDisableNetwork bool) ([]string, []string) {
329329
t.Helper()
330330

331331
clientPool := &clientPool{
@@ -336,7 +336,7 @@ func argsAndEnvWithGlobalDisableNetwork(t *testing.T, name, catalogYAML, configY
336336
},
337337
}
338338
return clientPool.argsAndEnv(&catalog.ServerConfig{
339-
Name: name,
339+
Name: "test-server",
340340
Spec: parseSpec(t, catalogYAML),
341341
Config: parseConfig(t, configYAML),
342342
Secrets: secrets,

0 commit comments

Comments
 (0)