ogc: always let application decide on mouse visibility (#59)

Our heuristics break the "Abbaye des Morts" game, which does not need a
mouse cursor and just calls `SDL_ShowCursor(SDL_DISABLE)` at startup.
Yet, with the current version of SDL, if the wiimote is pointed at the
screen we are still showing a cursor, overriding the application's
explicit decision. And the mouse cursor is useless, since the
application is not reacting to a mouse.

The code we are removing was mainly added with the intent of _hiding_
the mouse cursor when the wiimote was not pointed at the screen, and we
could indeed update it and keep it working just as an additional check
on whether the cursor should be shown or not, but we don't really have a
concrete use-case here.

Let's just remove it completely for now, and bring it back (still
respecting an explicit SDL_DISABLE setting, though!) if/when we see a
reason to.

Author: mardy

src/video/ogc/SDL_ogcevents.c

@@ -49,9 +49,6 @@ static const struct {
 
 static void pump_ir_events(_THIS)
 {
-    SDL_Mouse *mouse = SDL_GetMouse();
-    bool wiimote_pointed_at_screen = false;
-
     if (!_this->windows) return;
 
     if (!SDL_WasInit(SDL_INIT_JOYSTICK)) {
@@ -66,7 +63,6 @@ static void pump_ir_events(_THIS)
 
         if (!data->ir.valid) continue;
 
-        wiimote_pointed_at_screen = true;
         SDL_SendMouseMotion(_this->windows, i,
                             0, data->ir.x, data->ir.y);
 
@@ -81,18 +77,6 @@ static void pump_ir_events(_THIS)
             }
         }
     }
-
-    /* Unfortunately SDL in practice supports only one mouse, so we are
-     * consolidating all the wiimotes as a single device.
-     * Here we check if any wiimote is pointed at the screen, in which case we
-     * show the default cursor (the Wii hand); if not, then the default cursor
-     * is hidden. Note that this only affects applications which haven't
-     * explicitly set a cursor: the others remain in full control of whether a
-     * cursor should be shown or not. */
-    if (mouse && mouse->cur_cursor == mouse->def_cursor &&
-        mouse->cursor_shown != wiimote_pointed_at_screen) {
-        SDL_ShowCursor(wiimote_pointed_at_screen);
-    }
 }
 #endif