Switch YAML library used to sigs.k8s.io/yaml (#11)

* Update tests
* Ensure old contract respecting Marshaller interface is maintained

Author: 100mik

go.mod

@@ -7,14 +7,15 @@ require (
 	github.com/mattn/go-isatty v0.0.11
 	github.com/stretchr/testify v1.7.1
 	github.com/vito/go-interact v1.0.1
-	gopkg.in/yaml.v2 v2.3.0
+	sigs.k8s.io/yaml v1.3.0
 )
 
 require (
-	github.com/davecgh/go-spew v1.1.0 // indirect
+	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/mattn/go-colorable v0.1.4 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1 // indirect
 	golang.org/x/term v0.0.0-20220411215600-e5f449aeb171 // indirect
+	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c // indirect
 )

go.sum

@@ -2,8 +2,9 @@ github.com/cppforlife/color v1.9.1-0.20200716202919-6706ac40b835 h1:mYQweUIBD+TB
 github.com/cppforlife/color v1.9.1-0.20200716202919-6706ac40b835/go.mod h1:dYeVsKp1vvK8XjdTPR1gF+uk+9doxKeO3hqQTOCr7T4=
 github.com/creack/pty v1.1.7 h1:6pwm8kMQKCmgUg0ZHTm5+/YvRK0s3THD/28+T6/kk4A=
 github.com/creack/pty v1.1.7/go.mod h1:lj5s0c3V2DBrqTV7llrYr5NG6My20zk30Fl46Y7DoTY=
-github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
+github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
+github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo=
 github.com/fsnotify/fsnotify v1.4.9 h1:hsms1Qyu0jgnwNXIxa+/V/PDsU6CfLf6CNO8H7IWoS4=
 github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ=
@@ -78,7 +79,10 @@ gopkg.in/fsnotify.v1 v1.4.7/go.mod h1:Tz8NjZHkW78fSQdbUxIjBTcgA1z1m8ZHf0WmKUhAMy
 gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 h1:uRGJdciOHaEIrze2W8Q3AKkepLTh2hOroT7a+7czfdQ=
 gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7/go.mod h1:dt/ZhP58zS4L8KSrWDmTeBkI65Dw0HsyUHuEVlX15mw=
 gopkg.in/yaml.v2 v2.2.4/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
-gopkg.in/yaml.v2 v2.3.0 h1:clyUAQHOM3G0M3f5vQj7LuJrETvjVot3Z5el9nffUtU=
 gopkg.in/yaml.v2 v2.3.0/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
+gopkg.in/yaml.v2 v2.4.0 h1:D8xgwECY7CYvx+Y2n4sBz93Jn9JRvxdiyyo8CTfuKaY=
+gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
+sigs.k8s.io/yaml v1.3.0 h1:a2VclLzOGrwOHDiV8EfBGhvjHvP46CtW5j6POvhYGGo=
+sigs.k8s.io/yaml v1.3.0/go.mod h1:GeOyir5tyXNByN85N/dRIT9es5UQNerPYEKK56eTBm8=

ui/table/values.go

@@ -8,7 +8,7 @@ import (
 	"strings"
 	"time"
 
-	"gopkg.in/yaml.v2"
+	"sigs.k8s.io/yaml"
 )
 
 func NewValueString(s string) ValueString { return ValueString{S: s} }
@@ -129,6 +129,19 @@ func (t ValueInterface) String() string {
 		return ""
 	}
 
+	// Handles contract in older YAML library defined here:
+	// https://github.com/go-yaml/yaml/blob/v3/yaml.go#L44-L52
+	if i, ok := t.I.(interface{ MarshalYAML() (interface{}, error) }); ok {
+		v, err := i.MarshalYAML()
+		if err != nil {
+			return fmt.Sprintf("<serialization error> : %#v", t.I)
+		}
+		if v == nil {
+			return ""
+		}
+		t.I = v
+	}
+
 	bytes, err := yaml.Marshal(t.I)
 	if err != nil {
 		return fmt.Sprintf("<serialization error> : %#v", t.I)

ui/table/values_test.go

@@ -179,11 +179,17 @@ func TestValueInterface(t *testing.T) {
 		assert.Equal(t, ValueInterface{I: i}.String(), "key:\n  nested_key: nested_value")
 	})
 
-	t.Run("returns nested items as a string", func(t *testing.T) {
+	// Tests contract specified here: https://github.com/go-yaml/yaml/blob/v3/yaml.go#L44-L52
+	t.Run("respects Marshaller interface", func(t *testing.T) {
 		i := failsToYAMLMarshal{}
 		assert.Equal(t, ValueInterface{I: i}.String(), `<serialization error> : table_test.failsToYAMLMarshal{}`)
 	})
 
+	t.Run("returns error on failure", func(t *testing.T) {
+		i := map[string]interface{}{"foo": make(chan int)}
+		assert.Contains(t, ValueInterface{I: i}.String(), `<serialization error> :`)
+	})
+
 	t.Run("returns nil items as blank string", func(t *testing.T) {
 		assert.Equal(t, ValueInterface{I: nil}.String(), "")
 	})