Commit ab12443
authored
### What are you trying to accomplish?
A refactoring opportunity: after reading `createAckEvent()` and
`createTextEvent`'s definitions, I noticed that the only difference was
that the former passes in an empty string for its content.
### What approach did you choose and why?
I chose to update the body to use `createTextEvent()` directly, passing
an empty string for its `message` argument. Ran tests locally and in CI
to verify this works 👍
### What should reviewers focus on?
Nothing I haven't mentioned 😉
1 parent ecf55b9 commit ab12443
1 file changed
+1
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
| 5 | + | |
14 | 6 | | |
15 | 7 | | |
16 | 8 | | |
| |||
0 commit comments