SAAS-6950 Add encoding trigger name in codefresh delete trigger (#444)

* SAAS-6950 Add encoding trigger name in `codefresh delete trigger`

* SAAS-6901 Add test

Author: olegz-codefresh

lib/interface/cli/commands/trigger/delete.cmd.js

@@ -31,7 +31,7 @@ const command = new Command({
 
 
         console.log(`Trigger: ${event} was unlinked from the pipeline: ${pipeline}`);
-        await sdk.triggers.delete({ event, pipeline });
+        await sdk.triggers.delete({ event: encodeURIComponent(event), pipeline });
     },
 });
 

lib/interface/cli/commands/trigger/trigger.sdk.spec.js

@@ -1,3 +1,4 @@
+const mockedDelete = jest.fn();
 const getCmd = require('./get.cmd').toCommand();
 const deleteCmd = require('./delete.cmd').toCommand();
 const createCmd = require('./create.cmd').toCommand();
@@ -8,6 +9,13 @@ const request = require('requestretry');
 
 const DEFAULT_RESPONSE = request.__defaultResponse();
 
+jest.mock('../../../../logic', () => {
+    // eslint-disable-next-line global-require
+    const sdk = require('../../../../logic/sdk');
+    sdk.triggers = { delete: mockedDelete };
+    return { sdk };
+});
+
 describe('trigger commands', () => {
     beforeEach(async () => {
         request.__reset();
@@ -53,7 +61,16 @@ describe('trigger commands', () => {
         it('should handle deletion given name', async () => {
             const argv = { 'event-uri': 'uri', pipeline: 'pipeline' };
             await deleteCmd.handler(argv);
-            await verifyResponsesReturned([DEFAULT_RESPONSE]); // eslint-disable-line
+            expect(mockedDelete).toHaveBeenCalledWith({ event: 'uri', pipeline: 'pipeline' });
+        });
+        it('should encode trigger name', async () => {
+            const cronUri = 'cron:codefresh:0 0 1 1 1/1 ?:test:0b3fdb693d73';
+            const argv = { 'event-uri': cronUri, pipeline: 'pipeline' };
+            await deleteCmd.handler(argv);
+            expect(mockedDelete).toHaveBeenCalledWith({
+                event: encodeURIComponent(cronUri),
+                pipeline: 'pipeline',
+            });
         });
     });
 });

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.52.5",
+  "version": "0.52.6",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,